Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seed IPs, based on bitcoin.sipa.be crawler data #5532

Merged
merged 1 commit into from
Jan 6, 2015
Merged

Update seed IPs, based on bitcoin.sipa.be crawler data #5532

merged 1 commit into from
Jan 6, 2015

Conversation

sipa
Copy link
Member

@sipa sipa commented Dec 23, 2014

No description provided.

@laanwj
Copy link
Member

laanwj commented Dec 23, 2014

ACK

Btw: only 20 overlapping IPs between the old and new list, that's a curiously large shift.

@sipa
Copy link
Member Author

sipa commented Dec 25, 2014

This was constructed by taken the top 600 IPs, sorted by 30d-average availability. Not sure how the previous list was constructed.

@sipa
Copy link
Member Author

sipa commented Dec 25, 2014

Updated.

@laanwj laanwj added this to the 0.10.0 milestone Dec 27, 2014
@pstratem
Copy link
Contributor

Can you sort the new list?

This should make comparison in the future easier.

@sipa
Copy link
Member Author

sipa commented Jan 5, 2015

Significant update:

  • Updated the contrib/seeds/makeseeds.py script
  • Include @gmaxwell's ASN filtering
  • Updated the seeds from my crawler
  • Sort the results for determinism and future comparability

@gavinandresen
Copy link
Contributor

ACK

1 similar comment
@gmaxwell
Copy link
Contributor

gmaxwell commented Jan 5, 2015

ACK

pstratem
pstratem reviewed Jan 5, 2015
View reviewed changes
contrib/seeds/makeseeds.py
m = PATTERN_IPV4.match(sline[0])
if m is None:
return None
# Do IPv4 sanity check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use socket.inet_aton ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest code, and I'll change it. I don't care enough to spend more time to look up how that works.

@pstratem
Copy link
Contributor

pstratem commented Jan 5, 2015

ACK (beyond above bikeshedding)

@laanwj
Copy link
Member

laanwj commented Jan 6, 2015

Tested re-ACK w/ wiping peers.dat and -dnsseed=0,

DNS seeding disabled
... (wait some time)
Adding fixed seed nodes as DNS doesn't seem to be available.
receive version message: /Satoshi:0.9.3/: version 70002, blocks=337739, us=....:34254, peer=1
... (started syncing at high speed)

@laanwj laanwj merged commit be22b3d into bitcoin:master Jan 6, 2015
laanwj added a commit that referenced this pull request Jan 6, 2015
@laanwj
Merge pull request #5532
7b879d3 
be22b3d Update seed IPs, based on bitcoin.sipa.be crawler data (Pieter Wuille)
sipa added a commit that referenced this pull request Jan 6, 2015
@sipa @laanwj
Update seed IPs, based on bitcoin.sipa.be crawler data
58fda4d 
Rebased-From: be22b3d
Github-Pull: #5532
reddink added a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020
@reddink
Update seed IPs, based on bitcoin.sipa.be crawler data
08c3b3c 
Rebased-From: be22b3d
Github-Pull: bitcoin#5532

(cherry picked from commit 58fda4d)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sipa @laanwj @pstratem @gavinandresen @gmaxwell