dmg: fix deterministic dmg creation and docs #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ut ACK |
laanwj
added a commit
that referenced
this pull request
Jan 2, 2015
0d50c2f dmg: fix deterministic dmg creation and docs (Cory Fields)
reddink
added a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
Rebased-From: 0d50c2f Github-Pull: bitcoin#5569 (cherry picked from commit 221a380)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've verified that the process works by manually extracting the signature from rc1 and running it through the re-attaching procedure. Updated the docs and descriptors to fix versioning. Rather than bumping the version for each build, make the inputs version-less. Obviously they must match anyway.
In case anyone wishes to test (I've verified that the dmg works fine)
The detached signature can be found here:
https://bitcoincore.org/cfields/bitcoin-0.10.0rc1/signature.tar.gz
And the final deterministic dmg is here:
https://bitcoincore.org/cfields/bitcoin-0.10.0rc1/bitcoin-0.10.0rc1-osx-signed.dmg
Needs backport to 0.10.