-acceptnonstdtxn option to skip "non-standard transaction" checks #559

Closed
wants to merge 1 commit into
from

Projects

None yet

7 participants

@luke-jr
Member
luke-jr commented Oct 4, 2011

Adds a -acceptnonstdtxn option to allow miners to easily accept "non-standard" transactions

We probably want to amend this with a block for OP_NOP*?

@gavinandresen
Member

NACK -- I'll soften my position on non-standard transactions when there is a good fast-initial-download solution implemented and the transaction fee code is reworked.

@TheBlueMatt
Contributor

Non-standard transactions were disabled for a reason, and nothing has reasonably changed since then...why enable them or make it easy to do so?

@jgarzik
Member
jgarzik commented Dec 19, 2011

NAK'd, closing. People who really need this can modify the source.

@jgarzik jgarzik closed this Dec 19, 2011
@rebroad rebroad commented on the diff Jun 5, 2012
src/init.cpp
@@ -199,6 +199,7 @@ bool AppInit2(int argc, char* argv[])
" -rpcport=<port> \t\t " + _("Listen for JSON-RPC connections on <port> (default: 8332)\n") +
" -rpcallowip=<ip> \t\t " + _("Allow JSON-RPC connections from specified IP address\n") +
" -rpcconnect=<ip> \t " + _("Send commands to node running on <ip> (default: 127.0.0.1)\n") +
+ " -acceptnonstdtxn \t " + _("Accept \"non-standard\" transactions for relay and blocks\n") +
@rebroad
rebroad Jun 5, 2012 Contributor

it seems transaction is usually "tx" rather than "txn", isn't it?

@luke-jr
Member
luke-jr commented Oct 22, 2015

Considering that merging this would have avoided the recent sigop-flooding problem, can I get this reopened and reconsidered? (note it must be reopened before I can rebase/push the latest branch and get it updated)

@dcousens
Contributor

@luke-jr how would it have avoided that?

@luke-jr
Member
luke-jr commented Oct 22, 2015

The top commit since early 2014 limits sigops to a reasonable rate per bytes. This not only causes the fee logic to reflect the cost as expected, but also requires any attempt to spam sigops to also spam data meeting the block size before the block sigop limit.

@dcousens
Contributor

Fair enough, but, that isn't part of this PR?

@luke-jr
Member
luke-jr commented Oct 22, 2015

It is as soon as it gets reopened. (GitHub ignores updates when the PR is closed.)

@eragmus
eragmus commented Dec 3, 2015

Any update on this, @luke-jr? Identical attack resurfaced 3 days ago:

https://www.reddit.com/r/Bitcoin/comments/3ur5ma/stuck_transactions/

@luke-jr
Member
luke-jr commented Dec 3, 2015

That part was split into #7081

@eragmus
eragmus commented Dec 4, 2015

Okay, thanks!

@luke-jr luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 27, 2016
@luke-jr luke-jr Merge #559 accept_nonstdtxn 7aa54ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment