Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
-acceptnonstdtxn option to skip "non-standard transaction" checks #559
Conversation
|
NACK -- I'll soften my position on non-standard transactions when there is a good fast-initial-download solution implemented and the transaction fee code is reworked. |
|
Non-standard transactions were disabled for a reason, and nothing has reasonably changed since then...why enable them or make it easy to do so? |
|
NAK'd, closing. People who really need this can modify the source. |
jgarzik
closed this
Dec 19, 2011
luke-jr
referenced this pull request
Apr 20, 2012
Closed
Relay and accept transactions that personally benefit the user #1128
rebroad
commented on the diff
Jun 5, 2012
| @@ -199,6 +199,7 @@ bool AppInit2(int argc, char* argv[]) | ||
| " -rpcport=<port> \t\t " + _("Listen for JSON-RPC connections on <port> (default: 8332)\n") + | ||
| " -rpcallowip=<ip> \t\t " + _("Allow JSON-RPC connections from specified IP address\n") + | ||
| " -rpcconnect=<ip> \t " + _("Send commands to node running on <ip> (default: 127.0.0.1)\n") + | ||
| + " -acceptnonstdtxn \t " + _("Accept \"non-standard\" transactions for relay and blocks\n") + |
|
|
|
Considering that merging this would have avoided the recent sigop-flooding problem, can I get this reopened and reconsidered? (note it must be reopened before I can rebase/push the latest branch and get it updated) |
|
@luke-jr how would it have avoided that? |
|
The top commit since early 2014 limits sigops to a reasonable rate per bytes. This not only causes the fee logic to reflect the cost as expected, but also requires any attempt to spam sigops to also spam data meeting the block size before the block sigop limit. |
|
Fair enough, but, that isn't part of this PR? |
|
It is as soon as it gets reopened. (GitHub ignores updates when the PR is closed.) |
eragmus
commented
Dec 3, 2015
|
Any update on this, @luke-jr? Identical attack resurfaced 3 days ago:
|
|
That part was split into #7081 |
eragmus
commented
Dec 4, 2015
|
Okay, thanks! |
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 27, 2016
pushed a commit
to nomnombtc/bitcoin
that referenced
this pull request
May 14, 2017
luke-jr commentedOct 4, 2011
Adds a -acceptnonstdtxn option to allow miners to easily accept "non-standard" transactions
We probably want to amend this with a block for OP_NOP*?