New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx #5618
Conversation
IMO this is too granular. No need to micromanage every tool. We had this discussion before, and decided on a rough 'utils' split for anything not GUI or bitcoind. Edit: see #4690 for previous discussion. |
This keeps --with[out]-utils, but allows overriding it on a per-utility basis. At the very least, I will need this (either merged or patched in) for Gentoo, which builds each component from source individually. |
65d8155
to
ab4a543
Compare
Conflicts: qa/pull-tester/rpc-tests.sh
ab4a543
to
27f1e33
Compare
What will This pull has a merge commit in it, you need to get rid of that before it can be merged. |
Seems like NAK territory? We already covered this on IRC. You can do this at the make command line level for just about any project, with no need to complicate configure. |
There seems to be no interest in this, and earlier consensus on IRC was not to split out the flags this far, so I'm closing this. I think it can make sense to do this when different utilities have different outside dependency libraries, in which case people may be forced to install dependencies for an utility they're not interested in. But not now. |
This is now true FWIW. |
Yes, you mean bitcoin-tx doesn't need libevent. |
…abled a2a04a5 Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (Luke Dashjr) 92af71c configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx (Luke Dashjr) Pull request description: Includes #5618 (which the reasons for rejecting no longer hold true) Tree-SHA512: f30a8e4a2f70166b7cabef77c4674163b3a9da14c6a547d34f00d1056a19bf4d23e22851eea726fad2afc8735d5473ae91122c770b65ac3886663dc20e2c5b70
…tx is enabled a2a04a5 Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (Luke Dashjr) 92af71c configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx (Luke Dashjr) Pull request description: Includes dashpay#5618 (which the reasons for rejecting no longer hold true) Tree-SHA512: f30a8e4a2f70166b7cabef77c4674163b3a9da14c6a547d34f00d1056a19bf4d23e22851eea726fad2afc8735d5473ae91122c770b65ac3886663dc20e2c5b70
No description provided.