Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx #5618

Closed
wants to merge 2 commits into from

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Jan 8, 2015

No description provided.

@laanwj
Copy link
Member

laanwj commented Jan 8, 2015

IMO this is too granular. No need to micromanage every tool. We had this discussion before, and decided on a rough 'utils' split for anything not GUI or bitcoind.

Edit: see #4690 for previous discussion.

@luke-jr
Copy link
Member Author

luke-jr commented Jan 8, 2015

This keeps --with[out]-utils, but allows overriding it on a per-utility basis. At the very least, I will need this (either merged or patched in) for Gentoo, which builds each component from source individually.

@luke-jr luke-jr force-pushed the separate_utils branch 2 times, most recently from 65d8155 to ab4a543 Compare January 8, 2015 13:30
@laanwj
Copy link
Member

laanwj commented Apr 1, 2015

What will --with[out]-utils do after this change? I don't see any code to handle it, but my autotools-fu isn't that great.

This pull has a merge commit in it, you need to get rid of that before it can be merged.

@jgarzik
Copy link
Contributor

jgarzik commented Apr 1, 2015

Seems like NAK territory? We already covered this on IRC. You can do this at the make command line level for just about any project, with no need to complicate configure.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 1, 2015

@laanwj --with[out]-utils continues to function as it did previously, basically controlling the default for the new options.

@jgarzik Is there a way to do make install in that scenario?

@laanwj
Copy link
Member

laanwj commented Apr 8, 2015

@luke-jr Ah yes, I missed that default so I wondered how it worked.

@theuni mind taking a look here?

@laanwj
Copy link
Member

laanwj commented Jun 12, 2015

There seems to be no interest in this, and earlier consensus on IRC was not to split out the flags this far, so I'm closing this.

I think it can make sense to do this when different utilities have different outside dependency libraries, in which case people may be forced to install dependencies for an utility they're not interested in. But not now.

@luke-jr
Copy link
Member Author

luke-jr commented Mar 1, 2016

I think it can make sense to do this when different utilities have different outside dependency libraries, in which case people may be forced to install dependencies for an utility they're not interested in. But not now.

This is now true FWIW.

@laanwj
Copy link
Member

laanwj commented Mar 3, 2016

Yes, you mean bitcoin-tx doesn't need libevent.

maflcko pushed a commit that referenced this pull request Sep 27, 2018
…abled

a2a04a5 Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (Luke Dashjr)
92af71c configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx (Luke Dashjr)

Pull request description:

  Includes #5618 (which the reasons for rejecting no longer hold true)

Tree-SHA512: f30a8e4a2f70166b7cabef77c4674163b3a9da14c6a547d34f00d1056a19bf4d23e22851eea726fad2afc8735d5473ae91122c770b65ac3886663dc20e2c5b70
pravblockc referenced this pull request in pravblockc/dash Jul 28, 2021
…tx is enabled

a2a04a5 Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (Luke Dashjr)
92af71c configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx (Luke Dashjr)

Pull request description:

  Includes dashpay#5618 (which the reasons for rejecting no longer hold true)

Tree-SHA512: f30a8e4a2f70166b7cabef77c4674163b3a9da14c6a547d34f00d1056a19bf4d23e22851eea726fad2afc8735d5473ae91122c770b65ac3886663dc20e2c5b70
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants