configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx #5618

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@luke-jr
Member
luke-jr commented Jan 8, 2015

No description provided.

@laanwj
Member
laanwj commented Jan 8, 2015

IMO this is too granular. No need to micromanage every tool. We had this discussion before, and decided on a rough 'utils' split for anything not GUI or bitcoind.

Edit: see #4690 for previous discussion.

@laanwj laanwj added the Build system label Jan 8, 2015
@luke-jr
Member
luke-jr commented Jan 8, 2015

This keeps --with[out]-utils, but allows overriding it on a per-utility basis. At the very least, I will need this (either merged or patched in) for Gentoo, which builds each component from source individually.

@laanwj
Member
laanwj commented Apr 1, 2015

What will --with[out]-utils do after this change? I don't see any code to handle it, but my autotools-fu isn't that great.

This pull has a merge commit in it, you need to get rid of that before it can be merged.

@jgarzik
Member
jgarzik commented Apr 1, 2015

Seems like NAK territory? We already covered this on IRC. You can do this at the make command line level for just about any project, with no need to complicate configure.

@luke-jr
Member
luke-jr commented Apr 1, 2015

@laanwj --with[out]-utils continues to function as it did previously, basically controlling the default for the new options.

@jgarzik Is there a way to do make install in that scenario?

@laanwj
Member
laanwj commented Apr 8, 2015

@luke-jr Ah yes, I missed that default so I wondered how it worked.

@theuni mind taking a look here?

@laanwj
Member
laanwj commented Jun 12, 2015

There seems to be no interest in this, and earlier consensus on IRC was not to split out the flags this far, so I'm closing this.

I think it can make sense to do this when different utilities have different outside dependency libraries, in which case people may be forced to install dependencies for an utility they're not interested in. But not now.

@laanwj laanwj closed this Jun 12, 2015
@luke-jr
Member
luke-jr commented Mar 1, 2016

I think it can make sense to do this when different utilities have different outside dependency libraries, in which case people may be forced to install dependencies for an utility they're not interested in. But not now.

This is now true FWIW.

@laanwj
Member
laanwj commented Mar 3, 2016

Yes, you mean bitcoin-tx doesn't need libevent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment