Catch UTXO set read errors and shutdown #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipa
force-pushed
the
catcherror
branch
2 times, most recently
from
58f3272
to
62bc982
Compare
| try { | ||
| return CCoinsViewBacked::GetCoins(txid, coins); | ||
| } catch(const std::runtime_error& e) { | ||
| uiInterface.ThreadSafeMessageBox(strprintf("Error reading from database (%s), shutting down.", e.what()), "", CClientUIInterface::MSG_ERROR); |
There was a problem hiding this comment.
You can leave out the detailed error message in the UI. Just log it to debug.log for troubleshooting.
There was a problem hiding this comment.
Message also needs a _() for translation.
|
tested ACK |
|
utACK |
laanwj
added a commit
that referenced
this pull request
Jan 12, 2015
13cdce4 Catch UTXO set read errors and shutdown (Pieter Wuille)
|
After the fact ninja ACK. (seems to successfully shut down on my faulty test host) |
ghost
mentioned this pull request
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
Github-Pull: bitcoin#5619 Rebased-From: 13cdce4 (cherry picked from commit 4e7c219)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimally invasive patch to shutdown on LevelDB read errors from the chainstate. The block index does not need similar protection, as it's only read at startup.
Should apply cleanly to 0.10 as well.