Added a workaround for an Ubuntu bug which causes -fstack-protector-all t #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks completely reasonable to me. On non-broken systems it will be a no-op, so the workaround can remain indefinitely with no cost... and only get dropped when someone gets around to reviewing the hardening settings at some point in the future. I don't have a broken ubuntu system to try this on, but I can confirm that its harmless on F14's GCC 4.5.1. |
…ll to be disregarded.
|
ACK |
|
ACK, makefiles can never have enough hacks and workarounds :-) |
|
ACK |
gavinandresen
added a commit
that referenced
this pull request
Oct 24, 2011
Added a workaround for an Ubuntu bug which causes -fstack-protector-all t
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
Added a workaround for an Ubuntu bug which causes -fstack-protector-all t
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
May 17, 2017
request manager comments
kallewoof
pushed a commit
to kallewoof/bitcoin
that referenced
this pull request
Oct 4, 2019
…t it already blinded b08fcb1 RawFillBlinds needs to push blank pubkeys if output it already blinded (Gregory Sanders) Pull request description: Tree-SHA512: 7b6f718f00d01cfdfae698c89c7c1ba5d09c7624a27cce4bc1a3d6ea9ceebd03684da1c867fec6ac22f4520e0afaa2bd934bfda979402cc3364750b1dd98af70
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a workaround for an Ubuntu bug which causes -fstack-protector-all to be disregarded.
this causes some functions not to be protected and leads to a warning:
"warning: not protecting function: no buffer at least 8 bytes long"
The bug which this is working around: https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/691722