0.10 fix for crashes on OSX 10.6 #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strnlen is available at build-time but not at runtime, causing a crash. 0.11 drops support for 10.6, so this is not needed in master.
|
utACK |
|
@ericpashman @Pyanne Are you able to test this on 10.6? @jonasschnelli It might help if you spin up some test binaries incase they can't build from source. utACK for 0.10 branch |
|
utACK for 0.10 branch, I'm glad we don't need it on master |
laanwj
added a commit
that referenced
this pull request
Mar 19, 2015
8752b5c 0.10 fix for crashes on OSX 10.6 (Cory Fields)
|
@fanquake currently i have no easy option to build a non-master branch... will update my script soon and try to provide binaries. |
|
Did a quick test on 10.7 and 10.10. Runs as expected. |
|
sad face ACK |
|
Tested on 10.6. All is well. |
|
Thanks for testing!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @laanwj on IRC. Fixes #5797. This is a hammer approach, but it's the most straightforward.
strnlen is available at build-time but not at runtime, causing a crash.
0.11 drops support for 10.6, so this is not needed in master.