wallet: make it possible to disable transaction broadcast #5951
Conversation
laanwj
force-pushed
the
2015_03_wallet_disable_tx_broadcast
branch
4 times, most recently
from
3e7c915
to
cff1cf8
Compare
|
+1 to users not seeing the term "conflicted" when such is not the case. I don't know what else was considered but tracking a persistent seen-the-network status and showing "Not shared" or similar seems a good way to do this. |
|
@dgenr8 I think it was never the plan to leave it that way forever... In any case, the more complete and correct way to handle that is to change the conflict logic from checking if the txn is in the mempool already to checking if the it would be accepted into the mempool if it were tried; but thats a fair bit of work for what is otherwise a small feature, so it's not great to have to do it first. |
|
This functionality is already useful, temporarily showing the transaction as conflicted is arguably a small issue. Not saying it doesn't deserve to be fixed, but it could be done later. |
|
@laanwj getrawtransaction needs to check the wallet. :) (otherwise there is no way to getrawtransaction on a transaction you just created via the wallet) |
|
utACK. |
|
@jonasschnelli it doesn't actually work right now for the reason I described. |
|
It does actually work right now. I've tested it. As said in the opening post you can get the transaction hex using |
|
::facepalm:: I had completely forgotten about the existence of gettransaction and on account read that as getrawtransaction. |
|
(tested) ACK. |
|
tested ACK. |
This is an advanced feature which will disable any kind of automatic
transaction broadcasting in the wallet. This gives the user full control
of how the transaction is sent.
For example they can broadcast new transactions through some other
mechanism themselves, after getting the transaction hex through `gettransaction`.
This just adds the option `-walletbroadcast=<0,1>`. Right now these
transactions will get the status
Status: conflicted, has not been successfully broadcast yet
They shouldn't be shown as conflicted at all (`walletconflicts` is empty). This status
will go away when the transaction is received through the network.
laanwj
force-pushed
the
2015_03_wallet_disable_tx_broadcast
branch
from
41d08e0
to
77650cc
Compare
|
rebased and squashed to pull in @jonasschnelli 's RPC test, thanks! |
|
ut ACK |
77650cc add -walletbroadcast=0 rpc test (Jonas Schnelli) 6f25262 wallet: make it possible to disable transaction broadcast (Wladimir J. van der Laan)
This is an advanced feature which will disable any kind of automatic transaction broadcasting in the wallet. It gives the user full control of how their transactions are sent.
They can broadcast a new transaction through some other mechanism, or send it to the recipient directly, after getting the transaction hex through
gettransaction. This can be used to do #4564.It is an important step toward addressing #3828.
This just adds the option
-walletbroadcast=<0,1>. Right now with-walletbroadcast=0new transactions will get the status...which is a tad strange. This is just a visual issue, though, and goes away when the transaction is received through the network.
Edit: discussing with @gmaxwell on IRC we thought of a way to avoid this without arcane changes to conflict handling: keep track of the seen-the-network status of transactions internally. If the transaction was not seen on the network, either through our own broadcasting or from a third-party, show it with a different status