Add missing lock in submitblock #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just fixes the bug, it would be nice to use threadsafetey.h annotations, but I believe that requires build-system changes as well. |
| if (pindex->nStatus & BLOCK_FAILED_MASK) | ||
| return "duplicate-invalid"; | ||
| // Otherwise, we might only have the header - process the block before returning | ||
| bool fBlockPresent; |
There was a problem hiding this comment.
Little nit: wouldn't be better to explicitly initialize this to false here ?
TheBlueMatt
force-pushed
the
submitblocklock
branch
from
09834ee
to
eb63bf8
Compare
|
This looks good to me now. untested ACK. |
|
utACK |
1 similar comment
|
utACK |
laanwj
added a commit
that referenced
this pull request
Apr 14, 2015
eb63bf8 Fix missing lock in submitblock (Matt Corallo)
|
Cherry-picked to 0.10 as eae305f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also for 0.10