[QT] remove movable option for toolbar #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK, there is no need to have it moveable! |
jonasschnelli
force-pushed
the
2015/05/qt_toolbar_fix
branch
from
a32bfac
to
fb21862
Compare
|
utACK. Didn't even realize it was movable. |
|
utACK On Wednesday, May 20, 2015, Wladimir J. van der Laan <
|
laanwj
added a commit
that referenced
this pull request
May 20, 2015
fb21862 [QT] mainwindow toolbar must not be movable (Jonas Schnelli)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason why the toolbar should be movable. It can result in ugly situations and could prevent from improving the UX.