[Qt] extend rpc console peers tab #6209

Diapolo · 2015-06-01T07:20:44Z

add node id, ping wait, whitelisted and common height
rephrase some labels to make them easier to understand for users

laanwj · 2015-06-01T08:08:55Z

Post-0.11 utACK

jonasschnelli · 2015-06-01T08:14:22Z

utACK
Will test soon.

laanwj · 2015-06-01T11:16:18Z

src/qt/forms/rpcconsole.ui

+           </widget>
+          </item>
+          <item row="0" column="2">
+           <widget class="QCheckBox" name="peerWhitelisted">


Let's use yes/no here instead of a checkbox (more consistent with rest of the table)

laanwj · 2015-06-01T11:18:36Z

I don't think it was introduced in this pull, but the Synced Headers, Synched Blocks and Ban Score rows blink furiously between actual values and Fetching.. all the time. I think we should display the last known value if the fetching fails.

jonasschnelli · 2015-06-01T11:28:44Z

I would prefer the checkbox – but only – if you could also set the state. Together with banning options (#6158) it would be a adequate look and feel. On the other hand, checkboxes sometimes don't really imply a change before the users presses "save" or something similar.

Diapolo · 2015-06-01T11:32:17Z

@laanwj I changed to Yes/No and also we don't display Fetching... anymore. I also thought about making whitelisting an option but would prefer doing that via a context menu :).

Diapolo · 2015-06-01T11:41:02Z

@jonasschnelli If I find the time I'm going to further test your ban/unban pull and would like to add a context menu for it :).

jonasschnelli · 2015-06-01T11:46:29Z

Style wise, the peers view should get an update:

The table doesn't auto-expand its cols/width.
Because now we have more lines in the text key/value table, the chance is very high that you run into the situations as the screen below shows (truncated text because of line height).

@Diapolo: i can try to create a commit on top of your PR to improve the general look and feel of the peers view if you don't care about this.

jonasschnelli · 2015-06-01T11:48:53Z

@Diapolo: for banning/unbanning i think it would be more visible and more clear if the user could ban/unban over checkboxes or buttons at the peer details section (right part of the view) instead of a context menu. Context menus are not always comprehensible at first sight.

Diapolo · 2015-06-01T12:05:49Z

@jonasschnelli If my pull gets ACKs feel free to base a further UI polish on top, that's fine with me :). As for banning/unbanning, I think we should allow both options (click and via context menu).

Diapolo · 2015-06-01T12:36:14Z

Why is this failing the No Wallet build with:
"No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated"

Diapolo · 2015-06-01T13:35:44Z

@jonasschnelli Mind taking a look at commit 3, could be interresting as this just "kicks" a node via context menu :).

luke-jr · 2015-06-02T04:38:01Z

Concept ACK. I had to read the code to figure out what "Ping Wait" was, so maybe a tooltip explaining that it is the duration of a currently outstanding ping?

Diapolo · 2015-06-02T05:43:05Z

@luke-jr I'm fine with adding a tooltip for Ping Wait and yeah I also had to read the code to understand what it does ^^.

laanwj · 2015-06-02T06:54:15Z

I agree that a checkbox makes sense if the user would be able to change the value. However I don't see the point to be able to change whitelisting status on a connected node. I wouldn't want to encourage people to manually whitelist peers until they disconnect/reconnect. It's micro-management.

(I'm not against whitelist editing in the UI in itself, but not in this way, it should be more similar to the command line options)

laanwj · 2015-06-02T06:55:52Z

src/qt/rpcconsole.cpp

+void RPCConsole::disconnectSelectedNode()
+{
+    QString strNode = GUIUtil::getEntryData(ui->peerWidget, 0, PeerTableModel::Address);
+    while (CNode *bannedNode = FindNode(strNode.toStdString())) {


Why is this a loop?

For no reason I guess ^^... will update.

laanwj · 2015-06-02T06:58:55Z

Scope drift alert: let's focus here on improving the peers table, features such as kicking/banning from the peers list should be a separate feature pull.

Diapolo · 2015-06-02T07:30:47Z

@laanwj I just found that kicking feature sooo cool and easy I wanted to show it :). But right, I'll open a new pull for it. Did you test/review it?

Edit: Feature now in a seperate pull: #6217

jonasschnelli · 2015-06-02T19:40:51Z

Looks good!
Tested ACK.

Nit: One thing which might be worth a short discussion:
Because now there are 17 rows of key/value information this would fix the min window height to be slightly above 600px. This would break the peers window on 800x600 screens (which is okay for me, but you never know what kind of screens are used in node only wallet disabled environments).

I think a easy addition would be to deselect a selected peer if the user switches away from peers to console or net graph, etc. (or if he closes the console/debug window).
This would re-allow the user to change the height of the window below 600px.

Diapolo · 2015-06-03T06:33:30Z

I think a easy addition would be to deselect a selected peer if the user switches away from peers to console or net graph, etc. (or if he closes the console/debug window).
This would re-allow the user to change the height of the window below 600px.

@jonasschnelli Im not sure, how would that change redude the screens size?

jonasschnelli · 2015-06-03T06:50:31Z

@Diapolo: it wouldn't resize the screen automatically, but, it would allow to reduce the height/size below 600px. If you don't deselect the row, the 17row key/value will constraint the height above 600px.

Diapolo · 2015-06-06T08:40:54Z

@jonasschnelli See commit 3, this adds your suggestion. Switching away from peers tab clears the selection.

- add node id, ping wait, whitelisted and common height - rephrase some labels to make them easier to understand for users

Diapolo · 2015-06-12T09:49:00Z

@laanwj @jonasschnelli Maybe some final ACKs :)?

laanwj · 2015-06-12T14:49:49Z

ACK. Works for me.

e059726 [Qt] deselect peer when switching away from peers tab in RPC console (Philip Kaufmann) 7211ada [Qt] replace Boost foreach with Qt version peertablemodel.cpp (Philip Kaufmann) 1b0db7b [Qt] extend rpc console peers tab (Philip Kaufmann)

@jonasschnelli

3537c83 Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c5 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to #14798. The "Peers" tab of the "Debug" window improved to address comments #6209 (comment) (by @jonasschnelli) and #14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR: ![screenshot from 2019-01-09 22-01-36](https://user-images.githubusercontent.com/32963518/50927352-2e6fb700-1460-11e9-9173-582348210492.png) ![screenshot from 2019-01-09 22-02-11](https://user-images.githubusercontent.com/32963518/50927354-329bd480-1460-11e9-9926-d0eb0f026a35.png) ![screenshot from 2019-01-09 22-02-37](https://user-images.githubusercontent.com/32963518/50927358-3596c500-1460-11e9-864d-c8704451f3d9.png) Tree-SHA512: 3d086007f6d72930bc2fc3c395175adda0f1a7722de3842bc246ee4f3bfc5ebda4b9a626fb68a7ee8663a88d0842deb37c0c460ad84cc58e22f138acf8bc71ea

@jonasschnelli

Summary: 3537c8345c788a527bb4e1d00683ca7f8ee5fb1a Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c51909dc55e279baa81f063c169c9735105 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to #14798. The "Peers" tab of the "Debug" window improved to address comments bitcoin/bitcoin#6209 (comment) (by @jonasschnelli) and bitcoin/bitcoin#14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR: ![screenshot from 2019-01-09 22-01-36](https://user-images.githubusercontent.com/32963518/50927352-2e6fb700-1460-11e9-9173-582348210492.png) ![screenshot from 2019-01-09 22-02-11](https://user-images.githubusercontent.com/32963518/50927354-329bd480-1460-11e9-9926-d0eb0f026a35.png) ![screenshot from 2019-01-09 22-02-37](https://user-images.githubusercontent.com/32963518/50927358-3596c500-1460-11e9-864d-c8704451f3d9.png) --- Backport of Core [[bitcoin/bitcoin#15136 | PR15136]] Test Plan: ninja all ./qt/bitcoin-qt -testnet check out the Peers tab for correctness Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D8547

@jonasschnelli

3537c83 Do not deselect peer when switching away from tab (Hennadii Stepanov) b0037c5 Improve Peers tab layout (Hennadii Stepanov) Pull request description: This is an alternative to bitcoin#14798. The "Peers" tab of the "Debug" window improved to address comments bitcoin#6209 (comment) (by @jonasschnelli) and bitcoin#14798 (comment) (by @promag). This allows to keep the peer selection while navigating to other places and effectively reverts e059726. Screenshots with this PR: ![screenshot from 2019-01-09 22-01-36](https://user-images.githubusercontent.com/32963518/50927352-2e6fb700-1460-11e9-9173-582348210492.png) ![screenshot from 2019-01-09 22-02-11](https://user-images.githubusercontent.com/32963518/50927354-329bd480-1460-11e9-9926-d0eb0f026a35.png) ![screenshot from 2019-01-09 22-02-37](https://user-images.githubusercontent.com/32963518/50927358-3596c500-1460-11e9-864d-c8704451f3d9.png) Tree-SHA512: 3d086007f6d72930bc2fc3c395175adda0f1a7722de3842bc246ee4f3bfc5ebda4b9a626fb68a7ee8663a88d0842deb37c0c460ad84cc58e22f138acf8bc71ea

laanwj added the GUI label Jun 1, 2015

laanwj reviewed Jun 1, 2015
View reviewed changes

laanwj reviewed Jun 2, 2015
View reviewed changes

Philip Kaufmann added 3 commits June 11, 2015 08:38

[Qt] extend rpc console peers tab

1b0db7b

- add node id, ping wait, whitelisted and common height - rephrase some labels to make them easier to understand for users

[Qt] replace Boost foreach with Qt version peertablemodel.cpp

7211ada

[Qt] deselect peer when switching away from peers tab in RPC console

e059726

laanwj merged commit e059726 into bitcoin:master Jun 12, 2015

Diapolo deleted the Qt_peers branch June 15, 2015 05:53

hebasto mentioned this pull request Nov 24, 2018

qt: Fix deselecting peer when switching from peers to console tab #14798

Closed

hebasto mentioned this pull request Jan 9, 2019

qt: "Peers" tab overhaul #15136

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Qt] extend rpc console peers tab #6209

[Qt] extend rpc console peers tab #6209

Diapolo commented Jun 1, 2015

laanwj commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

laanwj Jun 1, 2015

laanwj commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

Diapolo commented Jun 1, 2015

Diapolo commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

Diapolo commented Jun 1, 2015

Diapolo commented Jun 1, 2015

Diapolo commented Jun 1, 2015

luke-jr commented Jun 2, 2015

Diapolo commented Jun 2, 2015

laanwj commented Jun 2, 2015

laanwj Jun 2, 2015

Diapolo Jun 2, 2015

laanwj commented Jun 2, 2015

Diapolo commented Jun 2, 2015

jonasschnelli commented Jun 2, 2015

Diapolo commented Jun 3, 2015

jonasschnelli commented Jun 3, 2015

Diapolo commented Jun 6, 2015

Diapolo commented Jun 12, 2015

laanwj commented Jun 12, 2015

[Qt] extend rpc console peers tab #6209

[Qt] extend rpc console peers tab #6209

Conversation

Diapolo commented Jun 1, 2015

laanwj commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

laanwj Jun 1, 2015

Choose a reason for hiding this comment

laanwj commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

Diapolo commented Jun 1, 2015

Diapolo commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

jonasschnelli commented Jun 1, 2015

Diapolo commented Jun 1, 2015

Diapolo commented Jun 1, 2015

Diapolo commented Jun 1, 2015

luke-jr commented Jun 2, 2015

Diapolo commented Jun 2, 2015

laanwj commented Jun 2, 2015

laanwj Jun 2, 2015

Choose a reason for hiding this comment

Diapolo Jun 2, 2015

Choose a reason for hiding this comment

laanwj commented Jun 2, 2015

Diapolo commented Jun 2, 2015

jonasschnelli commented Jun 2, 2015

Diapolo commented Jun 3, 2015

jonasschnelli commented Jun 3, 2015

Diapolo commented Jun 6, 2015

Diapolo commented Jun 12, 2015

laanwj commented Jun 12, 2015