DEPENDENT: Chainparams: Introduce N testnet chains to test different block sizes #6382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
2 times, most recently
from
4d8e7d9
to
cb64088
Compare
jtimon
changed the title
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
2 times, most recently
from
4d1a42a
to
6d33e08
Compare
This was referenced Jul 18, 2015
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
2 times, most recently
from
8f8eef1
to
321715d
Compare
|
Rebased after #6381. Also rebased back in time to 0.11: https://github.com/jtimon/bitcoin/tree/chainparams-sizetest-0.11 |
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
from
321715d
to
490793a
Compare
|
Spun up a node and block explorer on top of this PR: http://sizenet.yogh.io/#json:getinfo Availability subject to change, will jump back to the main chain when no longer needed - if needed at all. (still synching) |
This was referenced Aug 19, 2015
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
from
490793a
to
b4252f7
Compare
|
Rebased and fixed (see #6077 (comment) ). |
jtimon
changed the title
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
2 times, most recently
from
8237db6
to
e20dc9d
Compare
|
This wasn't passing travis because of a small bug in jtimon@989e374 (#6625). I will wait for travis to approve this to force push #6625. |
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
from
e20dc9d
to
1d17ddd
Compare
|
NACK. I think the code should exist for people to use for testing, but I dont think Bitcoin Core is the place to support a ton of test/benchmark chains. This is different from the regtest/testnet chains, which exist to create a bitcoin-in-a-box for testing, but which try to mimic Bitcoin where convinient for testing, not to test changes to Bitcoin itself. |
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
3 times, most recently
from
b332cd8
to
90bf990
Compare
14 tasks
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
3 times, most recently
from
8fdf0bd
to
729bf3b
Compare
…tion number This is a no-op change. For now, everything passes MAX_BLOCK_SIZE / 60, so the result matches what it would've before. Tests use a number equal to the number of transactions where necessary, to ensure that they're never rejected when blocksizesize isn't being tested.
This is a no-op change. Tests use a value of std::numeric_limits<uint64_t>::max() where necessary, to ensure that they're never rejected when size isn't being tested.
…sus.h (as functions) The following are now tied to a chain rather than being defined as global constants. Their values have not changed. nMinTxSize nMaxBlockSize nMaxTxSize nMaxBlockSigops nCoinbaseMaturity Also, for free (diff-wise): Blocksize: Turn MAX_BLOCK_SIZE (nMaxBlockSize) and MAX_BLOCK_SIGOPS (nMaxBlockSigops) into functions ...which take Consensus::Params as parameter This will be convenient to reduce the diff of any proposal that changes the blocksize as a hardfork
…of -testnet and -regtest
jtimon
force-pushed
the
chainparams-sizetest-0.11.99
branch
from
729bf3b
to
2e7cb31
Compare
|
Closing. It will be eventually replaced with a similar one that doesn't use block size as an example. |
jtimon
referenced
this pull request
in sipa/bitcoin
Apr 6, 2016
Rebased by Pieter Wuille. Cleanup by Matt Corallo.
jtimon
referenced
this pull request
in sipa/bitcoin
Apr 6, 2016
6 tasks
jtimon
added a commit
to jtimon/bitcoin
that referenced
this pull request
Mar 24, 2017
- Chainparams: Use a regular factory for creating chainparams - Chainparams: Get rid of CChainParams& Params(std::string) - Chainparams: Use the factory for pow tests Upstream: [0.13-chainparams-factory] (replaces bitcoin#6382)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates
std::numeric_limits<uint64_t>::max()new testchains, each one with a different maximum block size and genesis block.It would be generally good to have more people collecting data and
conduction simulations related to different consensus maximum block sizes.
This PR attempts to simplify that work.
Even if it may take long until it is merged (because it requires many
little steps to be taken first), this branch (or a fork of it) can be used right now for
testing purposes.
One can use it, for example, like this:
./src/qt/bitcoin-qt -chain=sizetest -debug -printtoconsole -gen=1 -genproclimit=20 -blocksize=2000000I will rebase and update the list of dependencies accordingly as
things get merged.
Dependencies:
Similar branches on top of older versions:
https://github.com/jtimon/bitcoin/tree/chainparams-sizetest-0.11