New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QT] cleanup icons #6505

Merged
merged 2 commits into from Aug 7, 2015

Conversation

Projects
None yet
6 participants
@MarcoFalke
Member

MarcoFalke commented Aug 2, 2015

  • Cleanup SVG code
  • Unify design ("Typicons" seems to have round edges)
  • Replace wifi icon with something new
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Aug 2, 2015

Member

@jonasschnelli Could you check if clock5.png displays correctly?

Edit: Fixed, see commit.

Member

MarcoFalke commented Aug 2, 2015

@jonasschnelli Could you check if clock5.png displays correctly?

Edit: Fixed, see commit.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Aug 2, 2015

Member

Nice! Thanks.
Will test and post some screenshots soon.

Member

jonasschnelli commented Aug 2, 2015

Nice! Thanks.
Will test and post some screenshots soon.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Aug 2, 2015

Member

Where did the "something new" network icon come from? What is its license? This needs to be updated in assets-attribution.md, and must be MIT or similar licensing terms.

Member

luke-jr commented Aug 2, 2015

Where did the "something new" network icon come from? What is its license? This needs to be updated in assets-attribution.md, and must be MIT or similar licensing terms.

@laanwj laanwj added the GUI label Aug 3, 2015

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Aug 3, 2015

Member

In general it looks very good.
The new net icons (instead of the "wifi" like icon) has a bit thin lines...

Please update the assets-attribution.md.
At least add yourself to the list of designers (https://github.com/MarcoFalke/bitcoin/blob/MarcoFalke-2015-icon-cleanup/doc/assets-attribution.md#jonas-schnelli) so it would be clear that you are publishing under the MIT license.

OSX:
bildschirmfoto 2015-08-03 um 10 39 56
bildschirmfoto 2015-08-03 um 10 37 27
bildschirmfoto 2015-08-03 um 10 40 17
bildschirmfoto 2015-08-03 um 10 40 13

LINUX:
bildschirmfoto 2015-08-03 um 10 58 08
bildschirmfoto 2015-08-03 um 10 57 59
bildschirmfoto 2015-08-03 um 10 57 55
bildschirmfoto 2015-08-03 um 10 57 33

Member

jonasschnelli commented Aug 3, 2015

In general it looks very good.
The new net icons (instead of the "wifi" like icon) has a bit thin lines...

Please update the assets-attribution.md.
At least add yourself to the list of designers (https://github.com/MarcoFalke/bitcoin/blob/MarcoFalke-2015-icon-cleanup/doc/assets-attribution.md#jonas-schnelli) so it would be clear that you are publishing under the MIT license.

OSX:
bildschirmfoto 2015-08-03 um 10 39 56
bildschirmfoto 2015-08-03 um 10 37 27
bildschirmfoto 2015-08-03 um 10 40 17
bildschirmfoto 2015-08-03 um 10 40 13

LINUX:
bildschirmfoto 2015-08-03 um 10 58 08
bildschirmfoto 2015-08-03 um 10 57 59
bildschirmfoto 2015-08-03 um 10 57 55
bildschirmfoto 2015-08-03 um 10 57 33

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Aug 3, 2015

I'm not a friend of the new connection symbols, that is a NACK on changing it that way.

Diapolo commented Aug 3, 2015

I'm not a friend of the new connection symbols, that is a NACK on changing it that way.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Aug 3, 2015

Member

@Diapolo: could you give us any objective reasons for your dislike? The current icon is mostly used for WiFi connections and therefore i think changing it makes sense. The new icons would more reflect a p2p "signal strength".

Member

jonasschnelli commented Aug 3, 2015

@Diapolo: could you give us any objective reasons for your dislike? The current icon is mostly used for WiFi connections and therefore i think changing it makes sense. The new icons would more reflect a p2p "signal strength".

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Aug 3, 2015

Member

I will try to make the wires thicker and make another commit of the new p2p-connection symbol, so it is easier not to merge it.

Member

MarcoFalke commented Aug 3, 2015

I will try to make the wires thicker and make another commit of the new p2p-connection symbol, so it is easier not to merge it.

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Aug 3, 2015

@jonasschnelli It reminds me of an USB-like symbol, a USB hub or something. Perhaps we should only use a color indicator red, orange, yellow and green (only if incoming connections are allowed).

Diapolo commented Aug 3, 2015

@jonasschnelli It reminds me of an USB-like symbol, a USB hub or something. Perhaps we should only use a color indicator red, orange, yellow and green (only if incoming connections are allowed).

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 3, 2015

Member

I like the new connection icon. Inventive.

NACK on using a color indicator. We've switched to single-color icons, let's stick to it.

Member

laanwj commented Aug 3, 2015

I like the new connection icon. Inventive.

NACK on using a color indicator. We've switched to single-color icons, let's stick to it.

MarcoFalke added some commits Aug 4, 2015

[QT] cleanup icons
* Cleanup SVG code
* Unify design ("Typicons" seem to have round edges)
* Fix transparency issue with clock5.png
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Aug 4, 2015

Member

I did the split into two commits, so we have:

  • First commit:

screenshot from 2015-08-04 12-29-13

  • Second commit (thicker wires):

screenshot from 2015-08-04 16-14-19

Member

MarcoFalke commented Aug 4, 2015

I did the split into two commits, so we have:

  • First commit:

screenshot from 2015-08-04 12-29-13

  • Second commit (thicker wires):

screenshot from 2015-08-04 16-14-19

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
Member

jonasschnelli commented Aug 4, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 5, 2015

Member

Looks great. ACK.
schermafdruk van 2015-08-05 11 49 38

Member

laanwj commented Aug 5, 2015

Looks great. ACK.
schermafdruk van 2015-08-05 11 49 38

@laanwj laanwj merged commit df9c2ee into bitcoin:master Aug 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 7, 2015

Merge pull request #6505
df9c2ee [Qt] replace wifi icon with network symbol (Marco)
9142867 [QT] cleanup icons (Marco)
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Aug 7, 2015

Member

Post merge ACK. I did have some screens to post but will leave it now.

On Friday, August 7, 2015, Wladimir J. van der Laan <
notifications@github.com> wrote:

Merged #6505 #6505.


Reply to this email directly or view it on GitHub
#6505 (comment).

Member

fanquake commented Aug 7, 2015

Post merge ACK. I did have some screens to post but will leave it now.

On Friday, August 7, 2015, Wladimir J. van der Laan <
notifications@github.com> wrote:

Merged #6505 #6505.


Reply to this email directly or view it on GitHub
#6505 (comment).

@MarcoFalke MarcoFalke deleted the MarcoFalke:MarcoFalke-2015-icon-cleanup branch Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment