New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QT] cleanup icons #6505
[QT] cleanup icons #6505
Conversation
maflcko
commented
Aug 2, 2015
- Cleanup SVG code
- Unify design ("Typicons" seems to have round edges)
- Replace wifi icon with something new
@jonasschnelli Could you check if Edit: Fixed, see commit. |
33ce3a8
to
c07a7c1
Compare
Nice! Thanks. |
Where did the "something new" network icon come from? What is its license? This needs to be updated in assets-attribution.md, and must be MIT or similar licensing terms. |
In general it looks very good. Please update the |
I'm not a friend of the new connection symbols, that is a NACK on changing it that way. |
@Diapolo: could you give us any objective reasons for your dislike? The current icon is mostly used for WiFi connections and therefore i think changing it makes sense. The new icons would more reflect a p2p "signal strength". |
I will try to make the wires thicker and make another commit of the new p2p-connection symbol, so it is easier not to merge it. |
@jonasschnelli It reminds me of an USB-like symbol, a USB hub or something. Perhaps we should only use a color indicator red, orange, yellow and green (only if incoming connections are allowed). |
I like the new connection icon. Inventive. NACK on using a color indicator. We've switched to single-color icons, let's stick to it. |
* Cleanup SVG code * Unify design ("Typicons" seem to have round edges) * Fix transparency issue with clock5.png
c07a7c1
to
d8fe6eb
Compare
d8fe6eb
to
df9c2ee
Compare
Tested ACK. |
df9c2ee [Qt] replace wifi icon with network symbol (Marco) 9142867 [QT] cleanup icons (Marco)
Post merge ACK. I did have some screens to post but will leave it now. On Friday, August 7, 2015, Wladimir J. van der Laan <
|