Removed contrib/bitrpc #6507
Merged
Removed contrib/bitrpc #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK Rationale: this is a (bad) example of using RPC from Python. If anywhere it belongs with the Python-RPC bindings, not in the bitcoin core repository. |
|
Nit: mention also needs to be removed from |
|
Removed from contrib/README.md |
|
ACK after squashing |
It's unclear if people are using this and if it's worth maintaining.
|
Squashed! |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Aug 5, 2015
9f5edb9 Removed contrib/bitrpc (Casey Rodarmor)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear if people are using this and if it's worth maintaining. The script has some problems, as mentioned in pr #5360.
This "fixes" issue #6500