Skip to content

Removed contrib/bitrpc#6507

Merged
laanwj merged 1 commit into
bitcoin:masterfrom
casey:remove-bitrpc
Aug 5, 2015
Merged

Removed contrib/bitrpc#6507
laanwj merged 1 commit into
bitcoin:masterfrom
casey:remove-bitrpc

Conversation

@casey
Copy link
Copy Markdown
Contributor

@casey casey commented Aug 3, 2015

It's unclear if people are using this and if it's worth maintaining. The script has some problems, as mentioned in pr #5360.

This "fixes" issue #6500

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Aug 3, 2015

ACK

Rationale: this is a (bad) example of using RPC from Python. If anywhere it belongs with the Python-RPC bindings, not in the bitcoin core repository.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Aug 3, 2015

Nit: mention also needs to be removed from contrib/README.md

@casey
Copy link
Copy Markdown
Contributor Author

casey commented Aug 3, 2015

Removed from contrib/README.md

@fanquake
Copy link
Copy Markdown
Member

fanquake commented Aug 3, 2015

ACK after squashing

It's unclear if people are using this and if it's worth maintaining.
@casey
Copy link
Copy Markdown
Contributor Author

casey commented Aug 3, 2015

Squashed!

@jonasschnelli
Copy link
Copy Markdown
Contributor

ACK

@laanwj laanwj merged commit 9f5edb9 into bitcoin:master Aug 5, 2015
laanwj added a commit that referenced this pull request Aug 5, 2015
9f5edb9 Removed contrib/bitrpc (Casey Rodarmor)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants