Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed contrib/bitrpc #6507

Merged
merged 1 commit into from Aug 5, 2015
Merged

Removed contrib/bitrpc #6507

merged 1 commit into from Aug 5, 2015

Conversation

@casey
Copy link
Contributor

casey commented Aug 3, 2015

It's unclear if people are using this and if it's worth maintaining. The script has some problems, as mentioned in pr #5360.

This "fixes" issue #6500

@laanwj
Copy link
Member

laanwj commented Aug 3, 2015

ACK

Rationale: this is a (bad) example of using RPC from Python. If anywhere it belongs with the Python-RPC bindings, not in the bitcoin core repository.

@laanwj
Copy link
Member

laanwj commented Aug 3, 2015

Nit: mention also needs to be removed from contrib/README.md

@casey
Copy link
Contributor Author

casey commented Aug 3, 2015

Removed from contrib/README.md

@fanquake
Copy link
Member

fanquake commented Aug 3, 2015

ACK after squashing

It's unclear if people are using this and if it's worth maintaining.
@casey
Copy link
Contributor Author

casey commented Aug 3, 2015

Squashed!

@jonasschnelli
Copy link
Member

jonasschnelli commented Aug 3, 2015

ACK

@laanwj laanwj merged commit 9f5edb9 into bitcoin:master Aug 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Aug 5, 2015
9f5edb9 Removed contrib/bitrpc (Casey Rodarmor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.