Removed contrib/bitrpc #6507

Merged
merged 1 commit into from Aug 5, 2015

Conversation

Projects
None yet
4 participants
@casey
Contributor

casey commented Aug 3, 2015

It's unclear if people are using this and if it's worth maintaining. The script has some problems, as mentioned in pr #5360.

This "fixes" issue #6500

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 3, 2015

Member

ACK

Rationale: this is a (bad) example of using RPC from Python. If anywhere it belongs with the Python-RPC bindings, not in the bitcoin core repository.

Member

laanwj commented Aug 3, 2015

ACK

Rationale: this is a (bad) example of using RPC from Python. If anywhere it belongs with the Python-RPC bindings, not in the bitcoin core repository.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 3, 2015

Member

Nit: mention also needs to be removed from contrib/README.md

Member

laanwj commented Aug 3, 2015

Nit: mention also needs to be removed from contrib/README.md

@casey

This comment has been minimized.

Show comment
Hide comment
@casey

casey Aug 3, 2015

Contributor

Removed from contrib/README.md

Contributor

casey commented Aug 3, 2015

Removed from contrib/README.md

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Aug 3, 2015

Member

ACK after squashing

Member

fanquake commented Aug 3, 2015

ACK after squashing

Removed contrib/bitrpc
It's unclear if people are using this and if it's worth maintaining.
@casey

This comment has been minimized.

Show comment
Hide comment
@casey

casey Aug 3, 2015

Contributor

Squashed!

Contributor

casey commented Aug 3, 2015

Squashed!

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
Member

jonasschnelli commented Aug 3, 2015

ACK

@laanwj laanwj merged commit 9f5edb9 into bitcoin:master Aug 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 5, 2015

Merge pull request #6507
9f5edb9 Removed contrib/bitrpc (Casey Rodarmor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment