[qt] [trivial] Delete icons, Cleanup spinner animation #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| angle=$(($i * 10)) | ||
| convert spinner-000.png -background "rgba(0,0,0,0.0)" -distort SRT $angle spinner-$value.png | ||
| convert ../src/spinner.png -background "rgba(0,0,0,0.0)" -distort SRT $angle spinner-$frame.png |
There was a problem hiding this comment.
Maybe use something like FILEDIR=$(dirname $0) instead of ../src. It would allow to run the script from everywhere and still get and place the files in and from the right directory.
added 2 commits
September 13, 2015 17:57
…ner.sh * Merge make_spinner.py into makespinner.sh * Also delete now unused imgs * Actually use all 36 frames for the spinner animation
maflcko
force-pushed
the
MarcoFalke-2015-spinnerAnimationFix
branch
from
af56803
to
9b1cdd7
Compare
|
utACK |
|
Agree re: cleanup, but you call this 'fix', but there is no description. |
|
Nothing broken. The spinner is skipping one frame. Changing |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Sep 21, 2015
9b1cdd7 [trivial] Remove obsolete pixmaps (MarcoFalke) d1acf93 [qt] [trivial] share/qt/make_spinner.py => src/qt/res/movies/makespinner.sh (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.