Fix chainstate serialized_size computation #6865

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
7 participants
@sipa
Member

sipa commented Oct 21, 2015

This was introduced in #6650 by a cherry-picked commit of mine.

@CodeShark

This comment has been minimized.

Show comment
Hide comment
@CodeShark

CodeShark Oct 21, 2015

Contributor

ACK

Contributor

CodeShark commented Oct 21, 2015

ACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Oct 21, 2015

Member

Seems we have tests that test for the incorrect behaviour?

Member

sipa commented Oct 21, 2015

Seems we have tests that test for the incorrect behaviour?

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Oct 21, 2015

Contributor

ACK

Contributor

dcousens commented Oct 21, 2015

ACK

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Oct 21, 2015

Member

ACK / Tested ACK. Also ... tests are not very meaningful if an effort isn't put in to verify that they're actually testing something. :(

Member

gmaxwell commented Oct 21, 2015

ACK / Tested ACK. Also ... tests are not very meaningful if an effort isn't put in to verify that they're actually testing something. :(

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Oct 22, 2015

Member

It was never 130000 bytes, the test hardcoded an obviously broken value-- not finding the error in the very thing it was testing; thus my complaint above. :(

Member

gmaxwell commented Oct 22, 2015

It was never 130000 bytes, the test hardcoded an obviously broken value-- not finding the error in the very thing it was testing; thus my complaint above. :(

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Oct 22, 2015

Member

ACK after test fixed

Member

laanwj commented Oct 22, 2015

ACK after test fixed

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Oct 27, 2015

Contributor

ditto @laanwj - ACK after test fixed

Contributor

jgarzik commented Oct 27, 2015

ditto @laanwj - ACK after test fixed

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Oct 28, 2015

Member

Test should be fixed, and fix was tested.

Member

sipa commented Oct 28, 2015

Test should be fixed, and fix was tested.

@gmaxwell gmaxwell merged commit 298e040 into bitcoin:master Oct 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

gmaxwell added a commit that referenced this pull request Oct 28, 2015

Merge pull request #6865
298e040 Fix chainstate serialized_size computation (Pieter Wuille)

laanwj added a commit to laanwj/bitcoin that referenced this pull request Oct 31, 2015

@str4d str4d referenced this pull request in zcash/zcash Aug 28, 2017

Merged

Bitcoin 0.12+ dbwrapper improvements #2598

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Dec 18, 2017

Merged

Add unittests for dbwrapper + blockchain.py rpc test #284

zkbot added a commit to zcash/zcash that referenced this pull request Jan 15, 2018

Auto merge of #2598 - str4d:2074-dbwrapper, r=<try>
Bitcoin 0.12+ dbwrapper improvements

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6650
  - Only refactor - excludes obfuscation
- bitcoin/bitcoin#6777
  - Excluding obfuscation-related changes
- bitcoin/bitcoin#6865
- bitcoin/bitcoin#6823
- bitcoin/bitcoin#6873
- bitcoin/bitcoin#7927
  - Excluding first commit (already included) and second commit (obfuscation-related)
- bitcoin/bitcoin#8467

Part of #2074.

litecoinz-project added a commit to litecoinz-project/litecoinz that referenced this pull request Mar 15, 2018

zkbot added a commit to zcash/zcash that referenced this pull request Apr 3, 2018

Auto merge of #2598 - str4d:2074-dbwrapper, r=str4d
Bitcoin 0.12+ dbwrapper improvements

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6650
  - Only refactor - excludes obfuscation
- bitcoin/bitcoin#6777
  - Excluding obfuscation-related changes
- bitcoin/bitcoin#6865
- bitcoin/bitcoin#6823
- bitcoin/bitcoin#6873
- bitcoin/bitcoin#7927
  - Excluding first commit (already included) and second commit (obfuscation-related)
- bitcoin/bitcoin#8467

Part of #2074.

zkbot added a commit to zcash/zcash that referenced this pull request Apr 3, 2018

Auto merge of #2598 - str4d:2074-dbwrapper, r=str4d
Bitcoin 0.12+ dbwrapper improvements

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6650
  - Only refactor - excludes obfuscation
- bitcoin/bitcoin#6777
  - Excluding obfuscation-related changes
- bitcoin/bitcoin#6865
- bitcoin/bitcoin#6823
- bitcoin/bitcoin#6873
- bitcoin/bitcoin#7927
  - Excluding first commit (already included) and second commit (obfuscation-related)
- bitcoin/bitcoin#8467

Part of #2074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment