Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] remove unneeded spaces from init.cpp #6921

Closed
wants to merge 1 commit into from
Closed

[Trivial] remove unneeded spaces from init.cpp #6921

wants to merge 1 commit into from

Conversation

Diapolo
Copy link

@Diapolo Diapolo commented Oct 31, 2015

No description provided.

@@ -873,7 +873,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
nPruneTarget = (uint64_t) nSignedPruneTarget;
if (nPruneTarget) {
if (nPruneTarget < MIN_DISK_SPACE_FOR_BLOCK_FILES) {
return InitError(strprintf(_("Prune configured below the minimum of %d MiB. Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024));
return InitError(strprintf(_("Prune configured below the minimum of %d MiB. Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not touch this last time because the translation was already done. Am I wrong?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO your changes with removing the "Error:" in front require a few re-translations, so that shouldn't matter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, ACK on this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Diapolo Maybe just get in this change? You can either force push it or wait until I submit my trivial branch (~every two weeks) with the trivial changes cherry-picked and bundled up.

@maflcko
Copy link
Member

maflcko commented Oct 31, 2015

Do we care about white space in comments? @laanwj said this will break git blame.

@Diapolo
Copy link
Author

Diapolo commented Oct 31, 2015

Sometimes I'm asking myself, why it seems just my trivial pulls create controversial discussions ^^.
@MarcoFalke If this gets NACKed in general, fell free to pick it up.

@laanwj
Copy link
Member

laanwj commented Oct 31, 2015

Sometimes I'm asking myself, why it seems just my trivial pulls create controversial discussions ^^

Because, to be entirely honest, all this trivial fudging around with spaces tends to annoy me as long as there are still 341 actual issues to be solved.

@laanwj laanwj closed this Oct 31, 2015
@btcdrak
Copy link
Contributor

btcdrak commented Oct 31, 2015

I think what would help going forward is to have some sort of simple CS checker as part of the continuous integration like travis, then less CS issues would get into the codebase in the first place.

@Diapolo Diapolo deleted the trivial_typo_space branch October 31, 2015 11:31
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants