New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trivial] remove unneeded spaces from init.cpp #6921
Conversation
@@ -873,7 +873,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) | |||
nPruneTarget = (uint64_t) nSignedPruneTarget; | |||
if (nPruneTarget) { | |||
if (nPruneTarget < MIN_DISK_SPACE_FOR_BLOCK_FILES) { | |||
return InitError(strprintf(_("Prune configured below the minimum of %d MiB. Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024)); | |||
return InitError(strprintf(_("Prune configured below the minimum of %d MiB. Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not touch this last time because the translation was already done. Am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO your changes with removing the "Error:" in front require a few re-translations, so that shouldn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, ACK on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Diapolo Maybe just get in this change? You can either force push it or wait until I submit my trivial branch (~every two weeks) with the trivial changes cherry-picked and bundled up.
Do we care about white space in comments? @laanwj said this will break |
Sometimes I'm asking myself, why it seems just my trivial pulls create controversial discussions ^^. |
Because, to be entirely honest, all this trivial fudging around with spaces tends to annoy me as long as there are still 341 actual issues to be solved. |
I think what would help going forward is to have some sort of simple CS checker as part of the continuous integration like travis, then less CS issues would get into the codebase in the first place. |
No description provided.