[WIP] Travis: Test build against system Qt4 #7142

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
Member

luke-jr commented Dec 1, 2015

No description provided.

Owner

laanwj commented Dec 1, 2015

Concept ACK on testing with qt4, but I'm not entirely happy about adding yet another build for this, Travis is slow enough these days.

Member

jonasschnelli commented Dec 1, 2015

Concept ACK.
Agree with @laanw but IMO another build is more valuable then a speedy CI.

Owner

laanwj commented Dec 1, 2015

@jonasschnelli I wonder if there's a compromise, if we can combine the qt4 build with one of the existing builds

Member

jonasschnelli commented Dec 1, 2015

We only have one linux "full" Qt5 build "32bit + dash". The other linux QT5 build does not build the wallet. Maybe it would be worth to change one of the windows builds (Win32) to build with Qt4? On the other hand, Qt4 mostly makes sense on Linux, but even though, a Win32 Qt4 build should at least detect most Qt4 incompatibilities.

Owner

laanwj commented Dec 1, 2015

Yeah. That may work.
Anyhow this is up to @theuni. Another option would be to combine this build with something else that we wanted to test already, so that it's not just added for qt4.

Member

luke-jr commented Dec 2, 2015

@theuni Can't seem to get this to build with Qt - any ideas? Shouldn't --with-qt=qt4 configure fail if it has a problem? :/

Member

luke-jr commented Dec 2, 2015

@laanwj Oh, an idea if Travis time is a concern: make this build use only system libraries (no depends). That's probably better test coverage anyway...

Owner

laanwj commented Dec 2, 2015

@laanwj Oh, an idea if Travis time is a concern: make this build use only system libraries (no depends). That's probably better test coverage anyway...

Not a bad idea because of the extra test coverage with old libraries, but I don't think that will save much time as the depends are supposed to be built once and cached anyway.

Member

MarcoFalke commented Dec 2, 2015

supposed to be built once and cached anyway.

Does travis cache between builds, I don't think so?

Owner

laanwj commented Dec 2, 2015

No, not between builds, I think. In most cases this would make no sense as they have different flags or even a different platform.

Member

theuni commented Dec 2, 2015

Right. To clarify, depends are cached and re-used for subsequent builds of the same config. Each config is an island though.

Personally, I don't think this is worth adding another build for. If anything, I'd rather do as @laanwj said and combine it with another.

Owner

laanwj commented Dec 3, 2015

Travis PR test is quite slow lately. I'd certainly prefer not to add another config.

Testing more obscure platforms and library versions (like Qt4) may be better suited for something like a nightly extended build (e.g. #7148)

Member

luke-jr commented Jan 13, 2016

Once #7339 is merged, I suggest this can be extended to test --without-libevent as well.

Owner

laanwj commented Jan 16, 2016

Closing, this is part of #7148 now

laanwj closed this Jan 16, 2016

laanwj reopened this May 25, 2017

Owner

laanwj commented Jun 24, 2017

Needs rebase.

Member

jtimon commented Jun 24, 2017

Concept ACK

Member

luke-jr commented Jul 5, 2017

Rebased, sorry for the delay

Contributor

TheBlueMatt commented Jul 11, 2017

Concept ACK. Only concern is are we willing to add more jobs to travis? Can we pay them to make things go faster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment