Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] fix coincontrol update issue when deleting a send coins entry #7282

Merged
merged 1 commit into from Jan 5, 2016

Conversation

@jonasschnelli
Copy link
Member

jonasschnelli commented Jan 4, 2016

Fixes #7278.

Only "count" visible send-coins-entries for size/fee calculation, because deleting send-coins-entries use the deleteLater() method.

Call updateTabsAndLabels() after qApp-> processEvents() to make sure, a just added entry response false when calling entry->isHidden().

@jonasschnelli jonasschnelli added the GUI label Jan 4, 2016
@MarcoFalke
Copy link
Member

MarcoFalke commented Jan 4, 2016

Tested ACK 621bd69 fixes #7278.

@laanwj
Copy link
Member

laanwj commented Jan 5, 2016

Thanks! utACK

@jonasschnelli jonasschnelli merged commit 621bd69 into master Jan 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jonasschnelli added a commit that referenced this pull request Jan 5, 2016
621bd69 [Qt] fix coincontrol update issue when deleting a send coin entry (Jonas Schnelli)
jonasschnelli added a commit that referenced this pull request Jan 5, 2016
Github-Pull: #7282
Rebased-From: 621bd69
@jonasschnelli jonasschnelli deleted the 2016/01/qt_cc_fee branch Jan 8, 2016
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.