Remove always true cases in wallet/crypter.cpp encrypt and decrypt function #7643
Conversation
| EVP_CIPHER_CTX_init(&ctx); | ||
| if (fOk) fOk = EVP_EncryptInit_ex(&ctx, EVP_aes_256_cbc(), NULL, chKey, chIV) != 0; | ||
|
|
||
| bool fOk = EVP_EncryptInit_ex(&ctx, EVP_aes_256_cbc(), NULL, chKey, chIV) != 0; |
There was a problem hiding this comment.
IMO this results in the same (remove code) as above.
The L66 EVP function only gets executed when fOk is true (which is always true at L66). fOk will then be set to true if the EVP function did not return 0.
I think the current code works right.
There was a problem hiding this comment.
... and looks ugly 8)
ACK
|
Yes. This code is cleaner. utACK. |
|
Change looks fine, but we're about to nuke it anyway with #5949. Would prefer to avoid the rebase. |
|
No strong opinion about the code change, but agree with @theuni. |
|
NACK, I like the previous code better because the "formatting" is uniform. Also, I am pretty sure the compiler will remove this case. Apart from that, agree with @theuni |
|
Yes, let's focus on getting #5949 merged instead. |
No description provided.