Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net2 debug option #7654

Closed
wants to merge 1 commit into from
Closed

Add net2 debug option #7654

wants to merge 1 commit into from

Conversation

rebroad
Copy link
Contributor

@rebroad rebroad commented Mar 8, 2016

I often want to enable net debugging, but currently it's too noisy for what I want. Move some of the more verbose net debugging messages to "net2", making "net" debugging more likely to be desired without being too verbose (like this description!).

@jonasschnelli
Copy link
Contributor

I think this makes sense. Although it would remove certain log output if people continue to use only debug=net. But IMO thats okay.
I personally would prefer something like debug=netverbose instead of net2.

@laanwj
Copy link
Member

laanwj commented Mar 11, 2016

I personally would prefer something like debug=netverbose instead of net2.

Agreed

@paveljanik
Copy link
Contributor

Concent ACK.
I too prefer netverbose.

@laanwj
Copy link
Member

laanwj commented Mar 18, 2016

@rebroad can you please update the name of the debug category, then we can get this merged.

@morcos
Copy link
Member

morcos commented Mar 22, 2016

LogPrint("net", "dropmessages DROPPING SEND MESSAGE\n"); at line 2492 should probably also be moved to the new category.

Also maybe out of scope for this PR but the debug logging around "received getdata" seems due for a cleanup.

@laanwj
Copy link
Member

laanwj commented Apr 2, 2016

Ping @rebroad

@laanwj
Copy link
Member

laanwj commented Apr 5, 2016

Closing due to inactivity.

@laanwj laanwj closed this Apr 5, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants