Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus: Policy: Move CFeeRate out of consensus module and create CPolicy interface #7820

Closed
wants to merge 9 commits into from
Closed

Consensus: Policy: Move CFeeRate out of consensus module and create CPolicy interface #7820

wants to merge 9 commits into from

Commits on Dec 2, 2016

  1. Consensus: Minimal way to move dust out of consensus

    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    b49e387 View commit details
    Browse the repository at this point in the history

  2. Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module 

    ...from amount.o to policy/feerate.o

Policy, because it moves policy code to the policy directory (common module)
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    25c6b82 View commit details
    Browse the repository at this point in the history

  3. Globals: Allow to parse arguments without implicitly using the argMap… 

    … global
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    7e2e6fe View commit details
    Browse the repository at this point in the history

  4. Policy: Introduce empty CPolicy interface and CDefaultPolicy implemen… 

    …tation
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    04f546d View commit details
    Browse the repository at this point in the history

  5. Globals: Policy: mempool and filterRounder are initialized before min… 

    …RelayTxFee

Therefore the default value before init::AppInit2() is being used always.
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    7cf8970 View commit details
    Browse the repository at this point in the history

  6. Policy: Encapsulate ::minRelayTxFee initialization behind CDefaultPol… 

    …icy::InitFromArgs()
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    9185a86 View commit details
    Browse the repository at this point in the history

  7. ERROR-unittest: Consensus: Policy: MOVEONLY-ish: Rename dust methods … 

    …from CTxOut to CPolicy

Consensus, because it moves non-consensus code out of the consensus module
Policy, because it moves policy code to the policy directory (server module)

Method Renames:
- s/CTxOut::GetDustThreshold(const CFeeRate&)/CDefaultPolicy::GetDustThreshold(const CTxOut&)/
- s/CTxOut::IsDust(const CFeeRate&)/CDefaultPolicy::AcceptDust(const CTxOut&)/
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    93f8f01 View commit details
    Browse the repository at this point in the history

  8. ERROR-unit-test_IsStandard: Policy: Introduce CPolicy::GetMinRelayFee… 

    …() and use it everywhere except for dust
    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    a56cbad View commit details
    Browse the repository at this point in the history

  9. Globals: Cleanly remove ::minRelayTxFee

    @jtimon
    jtimon committed Dec 2, 2016
    Copy the full SHA
    daabe73 View commit details
    Browse the repository at this point in the history