Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Add .DSYM to .gitignore #8119

Closed
wants to merge 1 commit into from

Conversation

fanquake
Copy link
Member

Add debug symbols to .gitignore

@laanwj
Copy link
Member

laanwj commented May 30, 2016

What OS is this for?

@btcdrak
Copy link
Contributor

btcdrak commented May 30, 2016

This is platform specific (OSX) and should be in your local global gitignore.

@laanwj
Copy link
Member

laanwj commented May 31, 2016

@btcdrak I think we have more OS-specific stuff in there, .e.g DS_store and *.exe. I think the criterion should be whether the file is generated while following our supported build process.
If it is, it should be in our .gitignore.
If not, and it is part of some IDE or other user specific tool, it belongs in that user's gitignore.

Apart from that, at some point in our we should encourage in our build documentation doing out-of-tree builds so that it is no longer an issue.

@sipa
Copy link
Member

sipa commented Jun 1, 2016

@laanwj That sounds like a good criterion.

@fanquake Can you comment?

@theuni
Copy link
Member

theuni commented Jun 1, 2016

ACK @laanwj's comment.

@fanquake
Copy link
Member Author

fanquake commented Jun 2, 2016

.DSYM are generated when running valgrind on OS X

@laanwj
Copy link
Member

laanwj commented Jun 3, 2016

I'd say valgrind fits squarely into the 'other tools' category, it's not something we ever launch from the build system.

@fanquake fanquake closed this Jun 3, 2016
@fanquake fanquake deleted the ignore_debug branch June 3, 2016 13:53
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants