[wallet] tests: Don't use floating point #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ typedef set<pair<const CWalletTx*,unsigned int> > CoinSet; | |||
|
|
|||
| BOOST_FIXTURE_TEST_SUITE(wallet_tests, WalletTestingSetup) | |||
|
|
|||
| static CWallet wallet; | |||
| static const CWallet wallet; | |||
There was a problem hiding this comment.
Aside: We create a global static wallet object here? I never knew, assumed these tests would use the wallet created in WalletTestingSetup.
|
utACK faa91b1 |
|
ACK faa91b1 |
maflcko
pushed a commit
that referenced
this pull request
Jun 18, 2016
faa91b1 [wallet] tests: Don't use floating point (MarcoFalke)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
faa91b1 [wallet] tests: Don't use floating point (MarcoFalke)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
faa91b1 [wallet] tests: Don't use floating point (MarcoFalke)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on the compiler to properly handle floating points. However, doing "some refactoring" triggers the floating point behavior to be unpredictable on different archs/compilers and the tests will fail. (e.g. 32 bit test binaries produced by the gnu compiler will fail)
It is trivial to get rid of that, so let's do it.