New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mempool consistency checks in unit tests #8222

Merged
merged 1 commit into from Jun 22, 2016

Conversation

Projects
None yet
5 participants
@sipa
Member

sipa commented Jun 18, 2016

This helped me discovered #8220.

I can't measure any slowdown for running the unit tests.

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Jun 18, 2016

Contributor

Concept ACK

Contributor

petertodd commented Jun 18, 2016

Concept ACK

@MarcoFalke MarcoFalke added the Tests label Jun 19, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jun 19, 2016

utACK 3775ff9

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Jun 19, 2016

Member

Tested ACK. Just a very slight reservation that perhaps a consistency check being enabled someday hides a bug.

Member

gmaxwell commented Jun 19, 2016

Tested ACK. Just a very slight reservation that perhaps a consistency check being enabled someday hides a bug.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 20, 2016

Member

Sounds like a good idea to me, concept ACK.

Just a very slight reservation that perhaps a consistency check being enabled someday hides a bug.

This just adds checks I, hope? It doesn't ever correct consistency?

Member

laanwj commented Jun 20, 2016

Sounds like a good idea to me, concept ACK.

Just a very slight reservation that perhaps a consistency check being enabled someday hides a bug.

This just adds checks I, hope? It doesn't ever correct consistency?

@laanwj laanwj merged commit 3775ff9 into bitcoin:master Jun 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 22, 2016

Merge #8222: Enable mempool consistency checks in unit tests
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8222: Enable mempool consistency checks in unit tests
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8222: Enable mempool consistency checks in unit tests
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8222: Enable mempool consistency checks in unit tests
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8222: Enable mempool consistency checks in unit tests
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment