Enable mempool consistency checks in unit tests #8222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
|
utACK 3775ff9 |
|
Tested ACK. Just a very slight reservation that perhaps a consistency check being enabled someday hides a bug. |
|
Sounds like a good idea to me, concept ACK.
This just adds checks I, hope? It doesn't ever correct consistency? |
laanwj
added a commit
that referenced
this pull request
Jun 22, 2016
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 28, 2017
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
3775ff9 Enable mempool consistency checks in unit tests (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helped me discovered #8220.
I can't measure any slowdown for running the unit tests.