New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] gbuild: Set memory explicitly (default is too low) #8358

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented Jul 18, 2016

gbuild has a default of around 2 GB, which is too low for 0.13.

@MarcoFalke MarcoFalke added the Docs label Jul 18, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 18, 2016

Member

2GB is too little even without any parallelism?
Does Ubuntu Trusty have so much runtime overhead? If so, another reason for switching to debian...

In any case, utACK

Member

laanwj commented Jul 18, 2016

2GB is too little even without any parallelism?
Does Ubuntu Trusty have so much runtime overhead? If so, another reason for switching to debian...

In any case, utACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 18, 2016

Member

Right, I guess the alternative would be to pass --num-make 1

Member

MarcoFalke commented Jul 18, 2016

Right, I guess the alternative would be to pass --num-make 1

@laanwj laanwj merged commit faa5931 into bitcoin:master Jul 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 26, 2016

Merge #8358: [doc] gbuild: Set memory explicitly (default is too low)
faa5931 [doc] gbuild: Set memory explicitly (default is too low) (MarcoFalke)

laanwj added a commit that referenced this pull request Jul 26, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 26, 2016

Member

Backported to 0.13 as cfd1280

Member

laanwj commented Jul 26, 2016

Backported to 0.13 as cfd1280

@PRabahy

This comment has been minimized.

Show comment
Hide comment
@PRabahy

PRabahy Jul 26, 2016

Contributor

https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#create-a-new-virtualbox-vm says "Memory Size: at least 1024MB, anything less will really slow down the build."

Contributor

PRabahy commented Jul 26, 2016

https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#create-a-new-virtualbox-vm says "Memory Size: at least 1024MB, anything less will really slow down the build."

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jul 26, 2016

Member

Pretty sure this will fail on 32-bit...

 $ qemu-system-x86_64 -m 3000
qemu-system-x86_64: at most 2047 MB RAM can be simulated
Member

luke-jr commented Jul 26, 2016

Pretty sure this will fail on 32-bit...

 $ qemu-system-x86_64 -m 3000
qemu-system-x86_64: at most 2047 MB RAM can be simulated

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1607-docBuild branch Jul 31, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 31, 2016

Member

@luke-jr I am pretty sure it already failed when you just copy pasted the command line on 32-bit and compiled 0.13.0.

If you feel strong about it, you can create a pull to mention --num-make 1.

Member

MarcoFalke commented Jul 31, 2016

@luke-jr I am pretty sure it already failed when you just copy pasted the command line on 32-bit and compiled 0.13.0.

If you feel strong about it, you can create a pull to mention --num-make 1.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 31, 2016

Member

@PRabahy Pull request welcome :)

Member

MarcoFalke commented Jul 31, 2016

@PRabahy Pull request welcome :)

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Sep 1, 2016

Member

@MarcoFalke -j2 works fine with -m2047.

Member

luke-jr commented Sep 1, 2016

@MarcoFalke -j2 works fine with -m2047.

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8358: [doc] gbuild: Set memory explicitly (default is too low)
faa5931 [doc] gbuild: Set memory explicitly (default is too low) (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 29, 2017

Merge #8358: [doc] gbuild: Set memory explicitly (default is too low)
faa5931 [doc] gbuild: Set memory explicitly (default is too low) (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Jan 8, 2018

Merge #8358: [doc] gbuild: Set memory explicitly (default is too low)
faa5931 [doc] gbuild: Set memory explicitly (default is too low) (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment