gettransaction RPC for non-wallet transactions #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
visual ACK |
|
Sanity tested OK; would be nice if it checked the memory pool for 0-confirmation "other people's" transactions. |
|
@gavinandresen done |
| CTxDB txdb("r"); | ||
| CTransaction tx; | ||
| CTxIndex txindex; | ||
| if (!tx.ReadFromDisk(txdb, COutPoint(hash, 0), txindex)) |
There was a problem hiding this comment.
Doesn't this ReadFromDisk() fail for memory pool transactions? I could've sworn memory pool txns weren't written to disk until they were included in a block...
|
Much more complete and totally reworked version pushed. |
|
Needs rebasing. Sipa broke everything using locks. >_< |
|
This needs rebasing (merges clean, but won't build) |
Works for wallet transactions, memory-pool transaction and block chain transactions. Available for all: * txid * version * locktime * size * coinbase/inputs/outputs * confirmations Available only for wallet transactions: * amount * fee * details * blockindex Available for wallet transactions and block chain transactions: * blockhash * time
|
rebased |
gmaxwell
added a commit
that referenced
this pull request
May 8, 2012
gettransaction RPC for non-wallet transactions
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
gettransaction RPC for non-wallet transactions
destenson
pushed a commit
to destenson/bitcoin--bitcoin
that referenced
this pull request
Jun 26, 2016
sipa
added a commit
to sipa/bitcoin
that referenced
this pull request
Oct 28, 2020
3967d96 Merge bitcoin#838: Make autotools check for all the used openssl functions 3734b68 Configure echo if openssl tests are enabled 6f54e69 Merge bitcoin#841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_ 8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_ e669277 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing ac05f61 Merge bitcoin#809: Stop treating ECDH as experimental e6e3d5d travis: add schnorrsig to valgrind and big endian platform test 353dff1 Stop treating ECDH as experimental git-subtree-dir: src/secp256k1 git-subtree-split: 3967d96
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 28, 2020
3967d96 Merge bitcoin#838: Make autotools check for all the used openssl functions 3734b68 Configure echo if openssl tests are enabled 6f54e69 Merge bitcoin#841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_ 8893f42 Avoids a potentially shortening size_t to int cast in strauss_wnaf_ e669277 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing ac05f61 Merge bitcoin#809: Stop treating ECDH as experimental e6e3d5d travis: add schnorrsig to valgrind and big endian platform test 353dff1 Stop treating ECDH as experimental git-subtree-dir: src/secp256k1 git-subtree-split: 3967d96
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for wallet transactions, memory-pool transaction and block chain
transactions.
Available for all:
Available only for wallet transactions:
Available for wallet transactions and block chain transactions: