[Qt] Add interactive mempool graph by jonasschnelli · Pull Request #8550 · bitcoin/bitcoin

jonasschnelli · 2016-08-19T19:30:50Z

Includes #8501

At the moment, the mempool graph is not very prominently placed (next to the debug window).

Features:

interactive graph with options for tx count, dynamic memory usage and minRelayFee/KB
collects stats in the background, changing the timespan will directly redraw (unlike our bandwidth graph)
Dynamic size drawing, window can be resized
The mempool graph is a QWidget which means, it could be placed together with other graphs in a combine multi-graph view (screensaver approach)

maflcko · 2016-08-19T20:05:58Z

Concept ACK. Will test later.

jonasschnelli · 2016-08-19T20:39:58Z

Added the missing button PNGs now to git. This should fix the compile issue.

luke-jr · 2016-08-19T20:44:51Z

Nice. Some people might want to see actual byte-size, weights, etc; probably will overflow the one-line-per-item paradigm quickly - maybe have a dropdown box to add stuff?

jonasschnelli · 2016-08-19T20:49:53Z

Yes. Dropdown box could make sense. Adding a second graph below or on the right that just plots different data would probably also look good.

maflcko · 2016-08-19T21:17:25Z

Nit: Fonts appear larger on my system. Otherwise this looks great!

maflcko · 2016-08-19T21:19:10Z

Nit: Missing value. I think this is in satoshis. What about using BTC?

jonasschnelli · 2016-08-20T08:20:05Z

Switched to "Arial" as font and added a auto-size-adjustment.
Also added the "charts" icon for the menu.

maflcko · 2016-08-20T08:27:04Z

Nit: run optimize-pngs and mention the icons in assets_attribution?

jonasschnelli · 2016-08-20T10:06:34Z

Optimized the pngs and added them to the assets attribution file.

ghost · 2016-08-20T11:26:41Z

Concept ACK.

isle2983 · 2016-08-21T23:21:49Z

Nit1: The graph window is always drawn on top of the main window, even when the main window is active. It makes it annoying to use the rest of the GUI while this is open.

Nit2: The quantity labels for the Dynamic Memory Usage values on the left hand side of the graph are cramped and cut off some of the characters. See "500.00 KB" in the screenshot. It is like that for larger values once it gets into the 100MBs too.

rebroad · 2016-08-24T09:40:01Z

I'm not sure what I'm doing wrong but I've merged this and the graph is empty, and has been for an hour now... :-s i.e. Dynamic Memory Usage is stuck on 0 bytes, Amount of Txs also 0, MinRelayFee also zero.

jonasschnelli · 2016-08-24T09:41:06Z

@rebroad: what does getmempoolinfo tells you? Are you in sync on mainnet (or testnet)?

rebroad · 2016-08-25T15:46:49Z

@jonasschnelli problem solved - I had blocksonly=1 in the config file!! It's working really nicely now - great job!! I love how it can be resized and the period of time changed without the graph resetting (unlike the network traffic graph!).

Also, ACK

fanquake · 2016-08-26T13:08:44Z

OS X screenshots:

luke-jr · 2016-08-27T04:23:26Z

Using images for basically-a-checkbox gives a non-native look on every system. It looks like we can just colour a QCheckBox?

paveljanik · 2016-09-07T10:13:25Z

Rebase needed.

Concept ACK

Agree about checkboxes...

jonasschnelli · 2016-09-09T07:04:42Z

Rebased on top of #8501

maflcko · 2016-09-09T11:04:35Z

@jonasschnelli What do you think about using QCheckBox with setPallette() as suggested by @luke-jr ?

I think Checkboxes are appropriate for now.

But we should consider using non-standard UI elements to improve the look and feel. I know, developers hate this. :-)

But have a look at #5896. I think people liked it because the look and feel was different then just "Arial 12 and standard UI elements".

Non-standard UI elements ruin the look and feel...

Not sure. That's probably a matter of taste.
The thing why I'd like to keep the non-standard UI elements is, that I'm using a QGraphicScene at this point. Adding a QWidget (checkbox) at this point breaks the flexibility of reusing the QGraphicScene and draw it in any scale.

I think the checkbox could be different then the one thats currently used. And it probably should be draw internally and not use a PNG.

Because it's a matter of taste is precisely why it should use standard UI elements. The standard element should do all the drawing. If the user doesn't like their standard widgets, they can change them.

paveljanik · 2016-09-15T07:33:58Z

Can you please do something with this long line? It is there ~3 times and does a simple thing - worth a better method to add a sample?

Hmm.. I think this line is reasonable? How would you improve it?

Pass const ref. mempool only and do the rest in the method?

I like the current layering concept. IMO its preferable that the stats.cpp module has no knowledge over the txmempool.h's classes, etc., I prefer to keep it as "dump" as possible.

jonasschnelli · 2017-11-22T22:33:06Z

Rebased.
It's currently not Qt4 compatible due to a lambda signal connect (travis reported / working on it).

laanwj · 2017-11-23T15:31:48Z

It's currently not Qt4 compatible due to a lambda signal connect (travis reported / working on it).

If it's a lot of work, feel free to leave "nice but not critical" features such as this out when compiling with Qt4.

PierreRochard · 2017-12-15T00:53:27Z

ACK with Qt5

jb55

Hmm for some reason I'm getting this error on my system:

qt/mempoolstats.cpp: In member function ‘void MempoolStats::drawChart()’:
qt/mempoolstats.cpp:183:42: error: ‘ceil’ was not declared in this scope
     maxValueSize = ceil(maxValueSize*0.11)*10; //use size steps of 10dip
                                          ^
qt/mempoolstats.cpp:256:108: error: ‘log10’ was not declared in this scope
     int64_t dynMemUsagelog10Val = pow(10.0f, floor(log10(maxDynMemUsage*paddingTopSizeFactor-minDynMemUsage)));
                                                                                                            ^
qt/mempoolstats.cpp:256:109: error: ‘floor’ was not declared in this scope
     int64_t dynMemUsagelog10Val = pow(10.0f, floor(log10(maxDynMemUsage*paddingTopSizeFactor-minDynMemUsage)));
                                                                                                             ^
qt/mempoolstats.cpp:256:110: error: ‘pow’ was not declared in this scope
     int64_t dynMemUsagelog10Val = pow(10.0f, floor(log10(maxDynMemUsage*paddingTopSizeFactor-minDynMemUsage)));
                                                                                                              ^

I fixed it with this patch:

diff --git a/src/qt/mempoolstats.cpp b/src/qt/mempoolstats.cpp
index 139efa1a9..af33a655b 100644
--- a/src/qt/mempoolstats.cpp
+++ b/src/qt/mempoolstats.cpp
@@ -8,6 +8,7 @@
 #include <qt/clientmodel.h>
 #include <qt/guiutil.h>
 #include <stats/stats.h>
+#include <math.h>
 
 static const char *LABEL_FONT = "Arial";
 static int LABEL_TITLE_SIZE = 22;

Sjors

I did not need @jb55's patch on MacOS 10.13.2.

Although it can wait for a followup commit, I would prefer if more of the UI was built using interface builder (see #11950). That would it easier for other to improve the looks.

This should be easy for the header section above the chart and the duration toggles below. It's probably not realistic for the grid and X, Y axis and colored lines, although it would be nice if they can be styled using visual tools.

I left some inline comments, but didn't see any must-fix stuff.

The drawChart() function is rather large. Some stuff needs to be drawn only once, other stuff maybe only when there's a resize. Maybe that can be split? It might be safer to move some of the calculations into their own functions and test those against boundary values.

Sjors · 2018-01-08T11:29:36Z

@@ -0,0 +1,423 @@
+// Copyright (c) 2016 The Bitcoin Core developers


Nit: bump to 2018?

Sjors · 2018-01-08T12:15:13Z

+    }
+
+    // draw vertical grid
+    int amountOfLinesV = 4;


Nit: numberOfLinesV

Sjors · 2018-01-08T12:16:01Z

+
+    QPainterPath dynMemUsageGridPath(QPointF(currentX, bottom));
+
+    // draw horizontal grid


Move grid drawing to a function?

Sjors · 2018-01-08T12:22:40Z

+
+    if (!titleItem)
+    {
+        // create labels (only once)


Move the once-only stuff to another function?

Sjors · 2018-01-08T12:23:42Z

+        QCheckBox *cb0 = new QCheckBox("Dynamic Memory Usage");
+        cb0->setStyleSheet("background-color: rgb(255,255,255);");
+        dynMemUsageSwitch = scene->addWidget(cb0);
+        connect(cb0, &QCheckBox::stateChanged, [cb0, this](){ drawDynMemUsage = cb0->isChecked(); drawChart(); });


Move the user interacting bits to another function?

Also, do these really need to get redrawn every time? I'm not worried about performance, just code complexity. Adding and removing UI elements where it's not needed might also make using the interface builder more difficult.

Sjors · 2018-01-08T12:31:54Z

+        connect(model, SIGNAL(mempoolStatsDidUpdate()), this, SLOT(drawChart()));
+}
+
+void MempoolStats::drawChart()


Rename to drawChartFrame()? It draws a lot more than the chart.

Sjors · 2018-01-08T12:32:32Z

+    allDataLabel->setPos((width()-totalWidth)/2.0+last10MinLabel->boundingRect().width()+lastHourLabel->boundingRect().width()+lastDayLabel->boundingRect().width()+30,height()-filterBottomPadding);
+
+    // don't paint the grind/graph if there are no or only a signle sample
+    if (vSamples.size() < 2)


drawEmptyChart()

Sjors · 2018-01-08T12:33:23Z

+    {
+        noDataItem->setVisible(true);
+        return;
+    }


else { drawChart(vSamples, ...) }

laanwj · 2018-05-14T09:37:45Z

This has been lingering for a long time. I would prefer if it makes it in, of course, it has tons of concept ACKs (the most of any open PR, according to bitcoinacks). But otherwise should we close and put this up for grabs?

laanwj · 2018-08-31T10:46:39Z

Although it would be really nice to have, this has been inactive for very long.
Closing and adding "up for grabs".

rebroad · 2020-08-20T04:53:17Z

@laanwj A rebased version of this seems to be in Bitcoin Knots. Should I open a new pull request using this rebased version?

jonatack · 2020-08-20T13:30:14Z

This looks very nice. @rebroad I would review/test it if you pick it up.

luke-jr · 2020-08-20T13:45:22Z

Note that #8501 was updated after this, and in a conflicting way. In Knots, I'm using an older version of it.

So there is some work to be done, but it sounds like a good idea since @jonasschnelli seems to have abandoned it.

(If you're not up to merging #8501 with this, maybe it'd be fine to use the older version in Knots and the code can be updated later when the RPC interface is added)

jarolrod · 2021-03-04T23:04:42Z

@hebasto I guess this isn't up for grabs anymore since it's been picked up again by jonasschnelli over on the GUI repo

rebroad · 2021-03-26T16:18:02Z

@hebasto This could still be up for grabs given that it was superior in various ways to the newer implementation - e.g. it could run in a separate window to the debug window - the timescales were changeable, and it also shows memory utilization, and fee filter.

hebasto · 2021-03-26T16:29:36Z

@rebroad

@hebasto This could still be up for grabs given that it was superior in various ways to the newer implementation - e.g. it could run in a separate window to the debug window - the timescales were changeable, and it also shows memory utilization, and fee filter.

The "Up for grabs" label means "nobody's working on it", isn't it?

laanwj · 2021-03-29T08:36:43Z

The "Up for grabs" label means "nobody's working on it", isn't it?

Yes. If you wanted to handle it in a different way, you should have picked it up yourself.

maflcko · 2021-03-29T08:56:37Z

Or leave a suggestion on the pull that picked it up ;)

rebroad · 2021-05-12T08:22:44Z

@rebroad

@hebasto This could still be up for grabs given that it was superior in various ways to the newer implementation - e.g. it could run in a separate window to the debug window - the timescales were changeable, and it also shows memory utilization, and fee filter.

The "Up for grabs" label means "nobody's working on it", isn't it?

Yes, it appears that no one is working on this - the fee graph is a different feature - related, but not the same. I think the UpForGrabs label ought to remain until someone is working on this particular graph.

@luke-jr are you still rebasing this?

rebroad · 2021-05-16T08:09:51Z

A current rebase is here - rebroad@3ecfd95

jonasschnelli added the GUI label Aug 19, 2016

jonasschnelli force-pushed the 2016/08/stats_qt branch 2 times, most recently from ae05dfa to cb2b429 Compare August 19, 2016 19:36

jonasschnelli force-pushed the 2016/08/stats_qt branch from cb2b429 to 7650b31 Compare August 19, 2016 20:38

maflcko reviewed Aug 19, 2016
View reviewed changes

Comment thread src/qt/mempoolstats.cpp Outdated

Copy link
Copy Markdown

Member

maflcko Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing value. I think this is in satoshis. What about using BTC?

jonasschnelli force-pushed the 2016/08/stats_qt branch from 7650b31 to 0c6e36f Compare August 20, 2016 08:18

jonasschnelli force-pushed the 2016/08/stats_qt branch 3 times, most recently from 1944167 to f62fae3 Compare August 20, 2016 10:05

jonasschnelli force-pushed the 2016/08/stats_qt branch from f62fae3 to d0d5c7d Compare September 9, 2016 07:00

maflcko reviewed Sep 9, 2016
View reviewed changes

paveljanik reviewed Sep 15, 2016

View reviewed changes

jonasschnelli force-pushed the 2016/08/stats_qt branch from 034d89e to cb21388 Compare November 22, 2017 21:05

jonasschnelli added 2 commits November 22, 2017 11:31

Add mempool statistics collector

9e83a88

[Qt] Add interactive mempool graph

63fb116

jonasschnelli force-pushed the 2016/08/stats_qt branch from cb21388 to 63fb116 Compare November 22, 2017 22:32

jb55 suggested changes Dec 29, 2017

View reviewed changes

Sjors reviewed Jan 8, 2018

View reviewed changes

maflcko added the Needs rebase label Jun 6, 2018

laanwj added the Up for grabs label Aug 31, 2018

laanwj closed this Aug 31, 2018

laanwj removed the Needs rebase label Oct 24, 2019

jonasschnelli mentioned this pull request Feb 19, 2020

Has anyone thought of integrating a Mempool Visualizer into Bitcoin Core? #18177

Closed

jonasschnelli mentioned this pull request Oct 23, 2020

WIP: mempool stats chart bitcoin-core/gui#108

Closed

4 tasks

hebasto removed the Up for grabs label Mar 4, 2021

ghost mentioned this pull request Sep 3, 2021

WIP qt: mempool stats chart bitcoin-core/gui#320

Closed

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

		@@ -0,0 +1,423 @@
		// Copyright (c) 2016 The Bitcoin Core developers


		QPainterPath dynMemUsageGridPath(QPointF(currentX, bottom));

		// draw horizontal grid

Conversation

jonasschnelli commented Aug 19, 2016

Uh oh!

maflcko commented Aug 19, 2016

Uh oh!

jonasschnelli commented Aug 19, 2016

Uh oh!

luke-jr commented Aug 19, 2016

Uh oh!

jonasschnelli commented Aug 19, 2016

Uh oh!

maflcko commented Aug 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Aug 20, 2016

Uh oh!

maflcko commented Aug 20, 2016

Uh oh!

jonasschnelli commented Aug 20, 2016

Uh oh!

ghost commented Aug 20, 2016

Uh oh!

isle2983 commented Aug 21, 2016

Uh oh!

rebroad commented Aug 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli commented Aug 24, 2016

Uh oh!

rebroad commented Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Aug 26, 2016

Uh oh!

luke-jr commented Aug 27, 2016

Uh oh!

paveljanik commented Sep 7, 2016

Uh oh!

jonasschnelli commented Sep 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Nov 22, 2017

Uh oh!

laanwj commented Nov 23, 2017

Uh oh!

PierreRochard commented Dec 15, 2017

Uh oh!

jb55 left a comment

Choose a reason for hiding this comment

Uh oh!

Sjors left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors Jan 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

rebroad commented Aug 24, 2016 •

edited

Loading

rebroad commented Aug 25, 2016 •

edited

Loading

Sjors Jan 8, 2018 •

edited

Loading

laanwj commented Aug 31, 2018 •

edited

Loading

rebroad commented Aug 20, 2020 •

edited

Loading

jonatack commented Aug 20, 2020 •

edited

Loading

rebroad commented May 12, 2021 •

edited

Loading