New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mruset and use it for setInventoryKnown #907

Merged
merged 1 commit into from Feb 28, 2012

Conversation

Projects
None yet
2 participants
@sipa
Member

sipa commented Feb 27, 2012

This prevents unbounded memory usage when a attacker spams a node with "inv" messages.

@gavinandresen

View changes

Show outdated Hide outdated src/mruset.h
bool empty() const { return set.empty(); }
iterator find(const key_type& k) const { return set.find(k); }
size_type count(const key_type& k) const { return set.count(k); }
bool inline friend operator==(const mruset& a, const mruset& b) { return a.set() == a.set(); }

This comment has been minimized.

@gavinandresen

gavinandresen Feb 27, 2012

Contributor

typo: == b.set()

@gavinandresen

gavinandresen Feb 27, 2012

Contributor

typo: == b.set()

This comment has been minimized.

@sipa

sipa Feb 27, 2012

Member

Seems I forgot to add the changes to this file to the commit; fixed

@sipa

sipa Feb 27, 2012

Member

Seems I forgot to add the changes to this file to the commit; fixed

@gavinandresen

This comment has been minimized.

Show comment
Hide comment
@gavinandresen

gavinandresen Feb 27, 2012

Contributor

ACK

Contributor

gavinandresen commented Feb 27, 2012

ACK

@gavinandresen gavinandresen merged commit c4341fa into bitcoin:master Feb 28, 2012

ptschip added a commit to ptschip/bitcoin that referenced this pull request Jan 12, 2018

Tidy up Transaction Details and clearly indicate what the label is. (#…
…907)

* Tidy up the transaction desc

When viewing the Transaction details the txn label and tx address
were just concatenated together.  While the address is obvious it
was not entirely clear what the label meant.  A new user would
have trouble understanding what they were looking at.  By appending
the label to the address and clearly prefixing the label with "label:"
there is no doubt as to what the user is looking at.

* fix formatting

ptschip added a commit to ptschip/bitcoin that referenced this pull request Jan 17, 2018

Tidy up Transaction Details and clearly indicate what the label is. (#…
…907)

* Tidy up the transaction desc

When viewing the Transaction details the txn label and tx address
were just concatenated together.  While the address is obvious it
was not entirely clear what the label meant.  A new user would
have trouble understanding what they were looking at.  By appending
the label to the address and clearly prefixing the label with "label:"
there is no doubt as to what the user is looking at.

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment