Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[Qt] Console: allow empty arguments #9329
Conversation
jonasschnelli
added
the
GUI
label
Dec 12, 2016
|
Maybe add a unit test to check this case? |
|
This doesn't appear to actually fix the problem at all: luke-jr/bitcoin@3710cf3 |
jonasschnelli
and others
added some commits
Dec 12, 2016
|
Added @luke-jr's unit test, added some more fixes. |
|
Here's a few more, including one that fails: RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest(abc,,abc)");
QVERIFY(result == "[\"abc\",\"\",\"abc\"]");
RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest(abc,,)"); // this one fails
QVERIFY(result == "[\"abc\",\"\",\"\"]");
RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest(abc )");
QVERIFY(result == "[\"abc\"]");
RPCConsole::RPCExecuteCommandLine(result, "rpcNestedTest( abc)");
QVERIFY(result == "[\"abc\"]"); |
|
Added more rules and tests.
|
Makes sense, I think. |
jonasschnelli commentedDec 12, 2016
Should fix #9210 and re-allow empty arguments like
command '' <more arg...>orcommand "" <more args...>.