New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relay compact block messages prior to full block connection #9375
Merged
Commits on Jan 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8017547 - Browse repository at this point
Copy the full SHA 8017547View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a0b2f4 - Browse repository at this point
Copy the full SHA 9a0b2f4View commit details -
[qa] Avoid race in preciousblock test.
If node 0 is sufficiently fast to announce its block to node 1, node 1 might already have the block by the time the node_sync_via_rpc loop gets around to node 1, resulting in the submitblock result "duplicate-inconclusive" as node 1 has the block, but prefers an alternate chain.
Configuration menu - View commit details
-
Copy full SHA for 8baaba6 - Browse repository at this point
Copy the full SHA 8baaba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 180586f - Browse repository at this point
Copy the full SHA 180586fView commit details
Commits on Jan 5, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 6987219 - Browse repository at this point
Copy the full SHA 6987219View commit details -
Configuration menu - View commit details
-
Copy full SHA for c802092 - Browse repository at this point
Copy the full SHA c802092View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eaec08 - Browse repository at this point
Copy the full SHA 9eaec08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5749a85 - Browse repository at this point
Copy the full SHA 5749a85View commit details -
Ensure we meet the BIP 152 old-relay-types response requirements
In order to do this, we must call ActivateBestChain prior to responding getdata requests for blocks which we announced using compact blocks. For getheaders responses we dont need code changes, but do note that we must reset the bestHeaderSent so that the SendMessages call re-announces the header in question. While we could do something smarter for getblocks, calling ActivateBestChain is simple and more obviously correct, instead of doing something more similar to getheaders. See-also the BIP clarifications at bitcoin/bips#486
Configuration menu - View commit details
-
Copy full SHA for 9eb67f5 - Browse repository at this point
Copy the full SHA 9eb67f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ae4fc - Browse repository at this point
Copy the full SHA c1ae4fcView commit details
Commits on Jan 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0df777d - Browse repository at this point
Copy the full SHA 0df777dView commit details
Commits on Jan 12, 2017
-
Call ActivateBestChain without cs_main/with most_recent_block
There is still a call to ActivateBestChain with cs_main if a peer requests the block prior to it being validated, but this one is more specifically-gated, so should be less of an issue.
Configuration menu - View commit details
-
Copy full SHA for 962f7f0 - Browse repository at this point
Copy the full SHA 962f7f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73666ad - Browse repository at this point
Copy the full SHA 73666adView commit details
Commits on Jan 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 02ee4eb - Browse repository at this point
Copy the full SHA 02ee4ebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.