Net: Turn some methods and params/variables const #9659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2017
TheBlueMatt
reviewed
Jan 31, 2017
src/net.cpp
Outdated
| @@ -1871,7 +1871,7 @@ void CConnman::ThreadMessageHandler() | |||
| // Send messages | |||
| { | |||
| LOCK(pnode->cs_sendProcessing); | |||
| GetNodeSignals().SendMessages(pnode, *this, flagInterruptMsgProc); | |||
| GetNodeSignals().SendMessages(pnode, *this); | |||
There was a problem hiding this comment.
Even if we dont use it now, I'm not sure we want to get rid of passing flagInterruptMsgProc through...there is a strong case for using it in 0.15.
|
General concept ack, with the exception of removing the flagInterruptMsg pass (but please do make it const) |
|
Great, it seems I was right on leaving the last commit separated, I'll leave it out. |
jtimon
force-pushed
the
0.14-net-more-const
branch
from
9c0d421
to
0729102
Compare
TheBlueMatt
reviewed
Feb 1, 2017
| @@ -754,7 +754,7 @@ const uint256& CNetMessage::GetMessageHash() const | |||
|
|
|||
|
|
|||
| // requires LOCK(cs_vSend) | |||
| size_t CConnman::SocketSendData(CNode *pnode) | |||
There was a problem hiding this comment.
Hmm...while technicall const for the CConnman, I'm not sure this "should be const" given that it is writing data to the peer itself...
There was a problem hiding this comment.
Well, writing to the peer itself here is writing to pnode, which isn't const, no?
|
utACK 0729102 |
laanwj
added a commit
that referenced
this pull request
Feb 6, 2017
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove currently unused interruptMsgProc param from SendMessages.
I guess some squashing can be done (but I'm worried that interruptMsgProc is planned to be used in SendMessages later).