Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] Fix recently introduced typos in comments #9696

Merged
merged 1 commit into from Feb 18, 2017
Merged

[trivial] Fix recently introduced typos in comments #9696

merged 1 commit into from Feb 18, 2017

Conversation

practicalswift
Copy link
Contributor

No description provided.

@practicalswift practicalswift mentioned this pull request Feb 6, 2017
Merged
@fanquake
Copy link
Member

fanquake commented Feb 6, 2017

Couldn't you have merged this into one of the two just-merged typo PRs. Rather than opening an pull-request to fix the same thing.

I can't believe new typos are being re-introduced this quickly anyways.

@fanquake fanquake added the Docs label Feb 6, 2017
@practicalswift
Copy link
Contributor Author

practicalswift commented Feb 6, 2017 •
edited

These typos were are all introduced in fairly recently merged PRs:

  • src/init.cpp: minimimum (minimum) - typo introduced in 7b1add3 on December 13:th
  • src/rpc/client.cpp: Specifiy (Specify) - typo introduced in 481f289 on November 12:th
  • src/rpc/misc.cpp: callsites (call sites) - typo introduced in 99464bc on January 19:th
  • src/utiltime.h: sytem (system) - typo introduced in 99464bc on January 19:th
  • src/validation.cpp: assumedvalid (assumevalid) - typo introduced in e440ac7 on January 6:th
  • src/validation.cpp: hashpower (hash power) - typo introduced in e440ac7 on January 6:th
  • src/validation.cpp: inadvertantly (inadvertently) - typo introduced in 4afbde6 on December 16:th
  • src/validation.cpp: connnected (connected) - typo introduced in 4afbde6 on December 16:th
  • src/validationinterface.h: tranactions (transactions) - typo introduced in 094e4b3 on December 16:th
  • src/wallet/rpcwallet.cpp: replacable (replaceable) - typo introduced in cc0243a on December 9:th
  • src/wallet/wallet.cpp: carefuly (carefully) - typo introduced in 094e4b3 on December 16:th

Please note that these are commit dates. Merge dates are likely a few weeks later on average.

@maflcko
Copy link
Member

maflcko commented Feb 7, 2017

utACK 2152f8e. In the future I'd suggest this is done only every 6 months (prior to every release).

jonasschnelli
jonasschnelli approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.
Trivial ACK 2152f8ee274839e85464937223ca1247d4dd5441

@paveljanik
Copy link
Contributor

ACK 2152f8e

@practicalswift
Copy link
Contributor Author

Fixed another typo ("tempoarily" → "temporarily"): 719292bbaeca1a0e4ae1d0e3c0823f0fca00ed05

@practicalswift
Copy link
Contributor Author

Anything needed before merge? :-)

@paveljanik
Copy link
Contributor

@practicalswift Please squash

@practicalswift
Copy link
Contributor Author

@paveljanik Squashed and pushed! :-)

@paveljanik
Copy link
Contributor

reACK 0c9b9b7

@fanquake
Copy link
Member

utACK 0c9b9b7

@maflcko maflcko merged commit 0c9b9b7 into bitcoin:master Feb 18, 2017
maflcko pushed a commit that referenced this pull request Feb 18, 2017
Merge #9696: [trivial] Fix recently introduced typos in comments
aa5fa64 
0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift)
@maflcko
Copy link
Member

maflcko commented Feb 18, 2017

utACK 0c9b9b7.

@practicalswift If you find some more typos, that is great, but please wait a few months until submitting a pull request. We have no pressure to fix all typos immediately, it is enough to do it twice a year or something.

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 29, 2018
@PastaPastaPasta
Merge bitcoin#9696: [trivial] Fix recently introduced typos in comments
3af098d 
0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift)
UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Jan 3, 2019
@PastaPastaPasta @UdjinM6
Backports 0.15 pr1 (#2590)
a49f412 
* Merge bitcoin#9744: Remove unused module from rpc-tests

a432aa0 Remove unused module from rpc-tests (Takashi Mitsuta)

* Merge bitcoin#9696: [trivial] Fix recently introduced typos in comments

0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift)

* Merge bitcoin#9657: Improve rpc-tests.py

a6a3e58 Various review markups for rpc-tests.py improvements (John Newbery)
3de3ccd Refactor rpc-tests.py (John Newbery)
afd38e7 Improve rpc-tests.py arguments (John Newbery)
91bffff Use argparse in rpc_tests.py (John Newbery)
1581ecb Use configparser in rpc-tests.py (John Newbery)

* Merge bitcoin#9724: Qt/Intro: Add explanation of IBD process

f6d18f5 Qt/Intro: Explain a bit more what will happen first time (Luke Dashjr)
50c5657 Qt/Intro: Storage shouldn't grow significantly with pruning enabled (Luke Dashjr)
9adb694 Qt/Intro: Move sizeWarningLabel text into C++ code (Luke Dashjr)

* Merge bitcoin#9794: Minor update to qrencode package builder

1bfe6b4 Use package name variable inside $(package)_file_name variable (Mitchell Cash)

* Merge bitcoin#9726: netbase: Do not print an error on connection timeouts through proxy

3ddfe29 netbase: Do not print an error on connection timeouts through proxy (Wladimir J. van der Laan)
13f6085 netbase: Make InterruptibleRecv return an error code instead of bool (Wladimir J. van der Laan)

* Merge bitcoin#9727: Remove fallbacks for boost_filesystem < v3

056aba2 Remove fallbacks for boost_filesystem < v3 (Wladimir J. van der Laan)

* Merge bitcoin#9485: ZMQ example using python3 and asyncio

b471daf Adddress nits, use asyncio signal handling, create_task (Bob McElrath)
4bb7d1b Add python version checks and 3.4 example (Bob McElrath)
5406d51 Rewrite to not use Polling wrapper for asyncio, link to python2.7 example (Bob McElrath)
5ea5368 ZMQ example using python3 and asyncio (Bob McElrath)

* Merge bitcoin#9807: RPC doc fix-ups.

851f6a3 [qa][doc] Correct rpc test options in readme (fanquake)
41e7219 [trivial] Add tests_config.ini to .gitignore (fanquake)

* Dashify

Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>

* Change file permissions

* update travis.yml -parallel -> --jobs
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Jul 11, 2019
@PastaPastaPasta @CryptoCentric
Backports 0.15 PR1
c632f58 
* Merge bitcoin#9744: Remove unused module from rpc-tests

a432aa0 Remove unused module from rpc-tests (Takashi Mitsuta)

* Merge bitcoin#9696: [trivial] Fix recently introduced typos in comments

0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift)

* Merge bitcoin#9657: Improve rpc-tests.py

a6a3e58 Various review markups for rpc-tests.py improvements (John Newbery)
3de3ccd Refactor rpc-tests.py (John Newbery)
afd38e7 Improve rpc-tests.py arguments (John Newbery)
91bffff Use argparse in rpc_tests.py (John Newbery)
1581ecb Use configparser in rpc-tests.py (John Newbery)

* Merge bitcoin#9724: Qt/Intro: Add explanation of IBD process

f6d18f5 Qt/Intro: Explain a bit more what will happen first time (Luke Dashjr)
50c5657 Qt/Intro: Storage shouldn't grow significantly with pruning enabled (Luke Dashjr)
9adb694 Qt/Intro: Move sizeWarningLabel text into C++ code (Luke Dashjr)

* Merge bitcoin#9794: Minor update to qrencode package builder

1bfe6b4 Use package name variable inside $(package)_file_name variable (Mitchell Cash)

* Merge bitcoin#9726: netbase: Do not print an error on connection timeouts through proxy

3ddfe29 netbase: Do not print an error on connection timeouts through proxy (Wladimir J. van der Laan)
13f6085 netbase: Make InterruptibleRecv return an error code instead of bool (Wladimir J. van der Laan)

* Merge bitcoin#9727: Remove fallbacks for boost_filesystem < v3

056aba2 Remove fallbacks for boost_filesystem < v3 (Wladimir J. van der Laan)

* Merge bitcoin#9485: ZMQ example using python3 and asyncio

b471daf Adddress nits, use asyncio signal handling, create_task (Bob McElrath)
4bb7d1b Add python version checks and 3.4 example (Bob McElrath)
5406d51 Rewrite to not use Polling wrapper for asyncio, link to python2.7 example (Bob McElrath)
5ea5368 ZMQ example using python3 and asyncio (Bob McElrath)

* Merge bitcoin#9807: RPC doc fix-ups.

851f6a3 [qa][doc] Correct rpc test options in readme (fanquake)
41e7219 [trivial] Add tests_config.ini to .gitignore (fanquake)

* Dashify

Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>

* Change file permissions

* update travis.yml -parallel -> --jobs
@practicalswift practicalswift deleted the fix-recently-introduced-typos branch April 10, 2021 19:30
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@practicalswift @fanquake @maflcko @paveljanik @jonasschnelli