[Trivial] Remove nonsense #undef foreach #9732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a preprocessor #undef for a macro that was never defined. Should make no difference to compiled code.
|
gives same binaries for me ACK 467df39 |
|
utACK 467df39 |
dcousens
approved these changes
Feb 9, 2017
|
Obvious ACK. This was added in #6654, without explanation. |
|
ACK 467df39 |
IIRC Qt defines this, and there was a conflict with that and some other dependency. But if it's no longer necessary that's great. |
|
utACK 467df39 |
laanwj
added a commit
that referenced
this pull request
Feb 28, 2017
467df39 Remove nonsense #undef foreach (John Newbery) Tree-SHA512: b8c3c6654eb8a9e5008a1923bee46f7ef9f8216c8f4f1b4662d82c26410ca8d8afe41e24e48a3e2e8b2a25c81c33795a4073dabfe357caf0aa820519d4fffc71
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Feb 27, 2018
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 5, 2019
467df39 Remove nonsense #undef foreach (John Newbery) Tree-SHA512: b8c3c6654eb8a9e5008a1923bee46f7ef9f8216c8f4f1b4662d82c26410ca8d8afe41e24e48a3e2e8b2a25c81c33795a4073dabfe357caf0aa820519d4fffc71
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 23, 2019
467df39 Remove nonsense #undef foreach (John Newbery) Tree-SHA512: b8c3c6654eb8a9e5008a1923bee46f7ef9f8216c8f4f1b4662d82c26410ca8d8afe41e24e48a3e2e8b2a25c81c33795a4073dabfe357caf0aa820519d4fffc71
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 25, 2019
467df39 Remove nonsense #undef foreach (John Newbery) Tree-SHA512: b8c3c6654eb8a9e5008a1923bee46f7ef9f8216c8f4f1b4662d82c26410ca8d8afe41e24e48a3e2e8b2a25c81c33795a4073dabfe357caf0aa820519d4fffc71
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
#undef foreachfrom txmempool.h. That preprocessordirective was added in 34628a1
(#6654) but there doesn't appear to be a
#define foreachanywhere in the codebase. The#undef directivedoesn'tactually do anything.