Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const to methods that do not modify the object for which it is called #9964

Merged
merged 1 commit into from Aug 16, 2017
Merged

Add const to methods that do not modify the object for which it is called #9964

merged 1 commit into from Aug 16, 2017

Conversation

practicalswift
Copy link
Contributor

No description provided.

@benma
Copy link

benma commented Mar 9, 2017 •
edited

isRestartRequired() in optionsmodel.(h|cpp) can also be made const, I think.

@practicalswift
Copy link
Contributor Author

@benma Thanks! Added and pushed.

@benma
Copy link

benma commented Mar 9, 2017

utACK 17d6213f1ed08ce9907b90d22cc9596267eeeb73

dcousens
dcousens approved these changes Mar 10, 2017
View reviewed changes
Copy link
Contributor

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@maflcko
Copy link
Member

maflcko commented Mar 10, 2017

utACK 17d6213f1ed08ce9907b90d22cc9596267eeeb

@paveljanik
Copy link
Contributor

utACK 17d6213

@jtimon
Copy link
Contributor

jtimon commented Mar 18, 2017 •
edited

utACK 17d6213f1ed08ce9907b90d22cc9596267eeeb73 (but if it compiles everything is correct, it is true that only adds const to methods that look like should be const).

@practicalswift
Copy link
Contributor Author

Adding link to "By default, make member functions const" (Con.2) in the C++ Core Guidelines.

@practicalswift practicalswift mentioned this pull request May 29, 2017
Merged
@practicalswift
Copy link
Contributor Author

Added a few additional methods.

@maflcko
Copy link
Member

maflcko commented Jul 30, 2017

utACK 6e8c48d

1 similar comment
@TheBlueMatt
Copy link
Contributor

utACK 6e8c48d

@paveljanik
Copy link
Contributor

re-utACK 6e8c48d

@maflcko maflcko merged commit 6e8c48d into bitcoin:master Aug 16, 2017
maflcko pushed a commit that referenced this pull request Aug 16, 2017
Merge #9964: Add const to methods that do not modify the object for w…
b6a4891 
…hich it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 19, 2019
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
3a88434 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 23, 2019
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
415ef1b 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 24, 2019
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
f79f375 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Nov 19, 2019
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
3a36532 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Nov 21, 2019
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
20009e3 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 9, 2019
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
7c3b9fa 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 1, 2020
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
26b9a6a 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
63e6138 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
0fe8343 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
3b3830b 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#9964: Add const to methods that do not modify the objec…
8302bd5 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
@practicalswift practicalswift deleted the const branch April 10, 2021 19:32
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 26, 2021
Merge bitcoin#9964: Add const to methods that do not modify the objec…
6de88a2 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jan 29, 2022
Merge bitcoin#9964: Add const to methods that do not modify the objec…
fd3a1fa 
…t for which it is called

6e8c48d Add const to methods that do not modify the object for which it is called (practicalswift)

Pull request description:

Tree-SHA512: a6888111ba16fb796e320e60806e1a77d36f545989b5405dc7319992291800109eab0b8e8c286b784778f41f1ff5289e7cb6b4afd7aec77f385fbcafc02cffc1
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@practicalswift @benma @maflcko @paveljanik @jtimon @TheBlueMatt @dcousens @fanquake