Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
p2p: Bare minimum to support UNIX sockets #9979
Two commit on top of #9919 (first adds the implementation, second adds a test).
Not sure I'm familiar enough with libevent to give more than a concept ack. I read through it & it looks great. Concept Ack.
utACK 9abf3c9, though many files are out of date.
I'm wondering why this is labeled "bare minimum to support UNIX sockets" and when support seems pretty complete. Are there other p2p features over unix sockets that you'd want to support?
I somewhat dread having to rebase this, but hope to do so in the near future.
There's no support in RPC calls yet, for example. Unix sockets can only be passed on the command line.
I didn't try rebasing, but the merge with master doesn't look bad at all. The only C++ code conflicts are mapMultiArgs -> gArgs replacements. There is a huge scary looking conflict in the test framework util.py, but it just comes from the initialize_chain function moving to another file, and the changes there are minor.