Skip to content

wallet: simplify EraseRecords by using 'ErasePrefix'

Cirrus CI / lint failed Feb 7, 2024 in 1m 32s

Task Summary

Instruction lint failed in 00:44

Details

✅ 00:03 clone
✅ 00:10 merge_base
✅ 00:01 test_runner
✅ 00:04 python
✅ 00:25 unshallow
❌ 00:44 lint

Requirement already satisfied: toml in /python_build/lib/python3.9/site-packages (from vulture==2.6) (0.10.2)
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

[notice] A new release of pip is available: 23.0.1 -> 24.0
[notice] To update, run: pip install --upgrade pip
++ SHELLCHECK_VERSION=v0.8.0
++ curl -sL https://github.com/koalaman/shellcheck/releases/download/v0.8.0/shellcheck-v0.8.0.linux.x86_64.tar.xz
++ tar --xz -xf - --directory /tmp/
++ mv /tmp/shellcheck-v0.8.0/shellcheck /usr/bin/
+ set -o errexit
+ ./ci/lint/06_script.sh
+ '[' -n '' ']'
+ '[' -n 29403 ']'
+ COMMIT_RANGE=HEAD~..HEAD
+ echo

+ git log --no-merges --oneline HEAD~..HEAD
b7b5e5b24 wallet: simplify EraseRecords by using 'ErasePrefix'
d8265e5d0 wallet: bdb batch 'ErasePrefix', do not create txn internally
086fae723 wallet: batch 'DelAddressBook' db write operations
99bc2733f wallet: clean redundancies in DelAddressBook
+ echo

+ test/lint/commit-script-check.sh HEAD~..HEAD
+ export COMMIT_RANGE
+ RUST_BACKTRACE=1
+ /lint_test_runner/test_runner
src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
GOOD
src/secp256k1 in HEAD currently refers to tree 4f5d0a37a5ce94a773267b04af331b5f680b0433
src/secp256k1 in HEAD was last updated in commit 29fde0223abc706925188014209eba75390a9df8 (tree 4f5d0a37a5ce94a773267b04af331b5f680b0433)
GOOD
src/minisketch in HEAD currently refers to tree a749309e1b4edf48091edb57da6de2e8a16498a5
src/minisketch in HEAD was last updated in commit e9f1d8c27261070d209a28570ad36fe91531cdd2 (tree a749309e1b4edf48091edb57da6de2e8a16498a5)
GOOD
src/leveldb in HEAD currently refers to tree bd49d3c60051c1a8d8f030fa4ba7a29237fe7479
src/leveldb in HEAD was last updated in commit 1a463c70a368fb20316e03efac273438cf47baa3 (tree bd49d3c60051c1a8d8f030fa4ba7a29237fe7479)
GOOD
src/crc32c in HEAD currently refers to tree 5a1b5f7188bd2181e2a71d431fff282d50058e46
src/crc32c in HEAD was last updated in commit 08269e54a9a74e06c9fb72720a216d8c4d4532a2 (tree 5a1b5f7188bd2181e2a71d431fff282d50058e46)
GOOD
Args used        : 210
Args documented  : 221
Args undocumented: 0
set()
Args unknown     : 11
{'-includeconf', '-zmqpubrawblock', '-zmqpubhashblockhwm', '-zmqpubsequence', '-zmqpubhashtx', '-zmqpubrawtx', '-zmqpubrawblockhwm', '-zmqpubhashblock', '-zmqpubhashtxhwm', '-zmqpubrawtxhwm', '-zmqpubsequencehwm'}
src/wallet/wallet.cpp: Expected 0 argument(s) after format string but found 1 argument(s): WalletLogPrintf("Error: cannot erase address book entry purpose/name\n", __func__)
^---- failure generated from lint-format-strings.py
Success: no issues found in 286 source files
src/test/fuzz/package_eval.cpp:214: non-existant ==> non-existent
src/test/span_tests.cpp:56: memeber ==> member
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt

^---- Failure generated from lint-*.py scripts!