Skip to content

net: Favor peers from addrman over fetching seednodes

Cirrus CI / lint failed Mar 8, 2024 in 2m 4s

Task Summary

Instruction lint failed in 01:08

Details

✅ 00:03 clone
✅ 00:09 merge_base
✅ 00:01 test_runner
✅ 00:04 python
✅ 00:28 unshallow
❌ 01:08 lint

libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux/m4'.
libtoolize: copying file 'build-aux/m4/libtool.m4'
libtoolize: copying file 'build-aux/m4/ltoptions.m4'
libtoolize: copying file 'build-aux/m4/ltsugar.m4'
libtoolize: copying file 'build-aux/m4/ltversion.m4'
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:39: installing 'build-aux/ar-lib'
configure.ac:37: installing 'build-aux/compile'
configure.ac:24: installing 'build-aux/config.guess'
configure.ac:24: installing 'build-aux/config.sub'
configure.ac:27: installing 'build-aux/install-sh'
configure.ac:27: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux/m4'.
libtoolize: copying file 'build-aux/m4/libtool.m4'
libtoolize: copying file 'build-aux/m4/ltoptions.m4'
libtoolize: copying file 'build-aux/m4/ltsugar.m4'
libtoolize: copying file 'build-aux/m4/ltversion.m4'
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:114: installing 'build-aux/compile'
configure.ac:51: installing 'build-aux/config.guess'
configure.ac:51: installing 'build-aux/config.sub'
configure.ac:58: installing 'build-aux/install-sh'
configure.ac:58: installing 'build-aux/missing'
src/Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
Args used        : 210
Args documented  : 221
Args undocumented: 0
set()
Args unknown     : 11
{'-zmqpubsequence', '-includeconf', '-zmqpubrawblockhwm', '-zmqpubhashblockhwm', '-zmqpubrawblock', '-zmqpubhashtxhwm', '-zmqpubrawtxhwm', '-zmqpubrawtx', '-zmqpubhashtx', '-zmqpubhashblock', '-zmqpubsequencehwm'}
This diff appears to have added new lines with trailing whitespace.
The following changes were suspected:

diff --git a/src/net.cpp b/src/net.cpp
@@ -2453,0 +2491,5 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
+    
+    
@@ -2462,0 +2521,2 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
+        

diff --git a/test/functional/p2p_seednode.py b/test/functional/p2p_seednode.py
@@ -0,0 +1,67 @@
+        seed_node =  "0.0.0.2"        
^---- failure generated from lint-whitespace.py
test/functional/p2p_seednode.py:17:1: F401 'test_framework.wallet.MiniWallet' imported but unused
test/functional/p2p_seednode.py:51:31: W291 trailing whitespace
^---- failure generated from lint-python.py

^---- ⚠️ Failure generated from lint-*.py scripts!
����