Skip to content

Remove redundant `-datacarrier` option

Cirrus CI / fuzzer,address,undefined,integer, no depends failed Apr 23, 2024 in 5m 1s

Task Summary

Instruction ci failed in 04:54

Details

✅ 00:03 clone
✅ 00:01 merge_base
❌ 04:54 ci

  CXX      test/fuzz/fuzz-parse_univalue.o
  CXX      test/fuzz/fuzz-partially_downloaded_block.o
  CXX      test/fuzz/fuzz-policy_estimator.o
  CXX      test/fuzz/fuzz-policy_estimator_io.o
  CXX      test/fuzz/fuzz-poolresource.o
  CXX      test/fuzz/fuzz-pow.o
  CXX      test/fuzz/fuzz-prevector.o
  CXX      test/fuzz/fuzz-primitives_transaction.o
  CXX      test/fuzz/fuzz-process_message.o
  CXX      test/fuzz/fuzz-process_messages.o
  CXX      test/fuzz/fuzz-protocol.o
  CXX      test/fuzz/fuzz-psbt.o
  CXX      test/fuzz/fuzz-random.o
  CXX      test/fuzz/fuzz-rbf.o
  CXX      test/fuzz/fuzz-rolling_bloom_filter.o
  CXX      test/fuzz/fuzz-rpc.o
  CXX      test/fuzz/fuzz-script.o
  CXX      test/fuzz/fuzz-script_assets_test_minimizer.o
  CXX      test/fuzz/fuzz-script_descriptor_cache.o
  CXX      test/fuzz/fuzz-script_flags.o
  CXX      test/fuzz/fuzz-script_format.o
  CXX      test/fuzz/fuzz-script_interpreter.o
test/fuzz/script.cpp:56:28: error: no matching function for call to 'IsStandard'
   56 |     bool is_standard_ret = IsStandard(script, std::nullopt, which_type);
      |                            ^~~~~~~~~~
./policy/policy.h:126:6: note: candidate function not viable: no known conversion from 'const nullopt_t' to 'unsigned int' for 2nd argument
  126 | bool IsStandard(const CScript& scriptPubKey, unsigned max_datacarrier_bytes, TxoutType& whichType);
      |      ^                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:17750: test/fuzz/fuzz-script.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[1]: *** [Makefile:20164: install-recursive] Error 1
make[1]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make: *** [Makefile:755: install-recursive] Error 1
Build failure. Verbose build follows.
+ echo 'Build failure. Verbose build follows.'
+ make install V=1
Making install in src
make[1]: Entering directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[2]: Entering directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
/usr/bin/ccache clang++-18 -ftrivial-auto-var-init=pattern -std=c++20 -DHAVE_CONFIG_H -I. -I../src/config  -DABORT_ON_FAILED_ASSUME -fmacro-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -DHAVE_BUILD_INFO -I. -I./minisketch/include -I./secp256k1/include -I./univalue/include -I/usr/include -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_NO_CXX98_FUNCTION_BASE  -g -O2 -fdebug-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wno-unused-parameter -Wno-self-assign -Werror  -fsanitize=fuzzer,address,undefined,float-divide-by-zero,integer -fPIE  -c -o test/fuzz/fuzz-script.o `test -f 'test/fuzz/script.cpp' || echo './'`test/fuzz/script.cpp
test/fuzz/script.cpp:56:28: error: no matching function for call to 'IsStandard'
   56 |     bool is_standard_ret = IsStandard(script, std::nullopt, which_type);
      |                            ^~~~~~~~~~
./policy/policy.h:126:6: note: candidate function not viable: no known conversion from 'const nullopt_t' to 'unsigned int' for 2nd argument
  126 | bool IsStandard(const CScript& scriptPubKey, unsigned max_datacarrier_bytes, TxoutType& whichType);
      |      ^                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:17750: test/fuzz/fuzz-script.o] Error 1
make[2]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[1]: *** [Makefile:20164: install-recursive] Error 1
make[1]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make: *** [Makefile:755: install-recursive] Error 1

Exit status: 2�