Skip to content

refactor: remove warnings globals

Cirrus CI / tidy failed May 7, 2024 in 1m 41s

Task Summary

Instruction ci failed in 01:34

Details

✅ 00:03 clone
✅ 00:01 merge_base
❌ 01:34 ci

   40 |     void warningSet(const std::string& id, const bilingual_str& warning) override;
      |                                                                          ^
./kernel/notifications_interface.h:41:18: note: hidden overloaded virtual function 'kernel::Notifications::warningSet' declared here: type mismatch at 1st parameter ('const int &' vs 'const std::string &' (aka 'const basic_string<char> &'))
   41 |     virtual void warningSet(const std::string& id, const bilingual_str& warning) {}
      |                  ^
In file included from node/kernel_notifications.cpp:5:
./node/kernel_notifications.h:42:46: error: non-virtual member function marked 'override' hides virtual member function
   42 |     void warningUnset(const std::string& id) override;
      |                                              ^
./kernel/notifications_interface.h:42:18: note: hidden overloaded virtual function 'kernel::Notifications::warningUnset' declared here: type mismatch at 1st parameter ('const int &' vs 'const std::string &' (aka 'const basic_string<char> &'))
   42 |     virtual void warningUnset(const std::string& id) {}
      |                  ^
4 errors generated.
make[2]: *** [Makefile:10596: node/libbitcoin_node_a-kernel_notifications.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[1]: *** [Makefile:20129: install-recursive] Error 1
make[1]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make: *** [Makefile:754: install-recursive] Error 1
Build failure. Verbose build follows.
+ echo 'Build failure. Verbose build follows.'
+ make install V=1
Making install in src
make[1]: Entering directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[2]: Entering directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
/usr/bin/ccache clang++-18 -std=c++20 -DHAVE_CONFIG_H -I. -I../src/config  -fmacro-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=.  -DHAVE_BUILD_INFO -DPROVIDE_FUZZ_MAIN_FUNCTION -I. -I./minisketch/include -I./secp256k1/include -I./univalue/include -I./leveldb/include -I/usr/include -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_NO_CXX98_FUNCTION_BASE       -g -O2 -fdebug-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=.  -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wno-unused-parameter -Wno-self-assign -Werror    -O0 -g0 -c -o node/libbitcoin_node_a-kernel_notifications.o `test -f 'node/kernel_notifications.cpp' || echo './'`node/kernel_notifications.cpp
In file included from node/kernel_notifications.cpp:5:
In file included from ./node/kernel_notifications.h:8:
./kernel/notifications_interface.h:41:40: error: no type named 'string' in namespace 'std'
   41 |     virtual void warningSet(const std::string& id, const bilingual_str& warning) {}
      |                                   ~~~~~^
./kernel/notifications_interface.h:42:42: error: no type named 'string' in namespace 'std'
   42 |     virtual void warningUnset(const std::string& id) {}
      |                                     ~~~~~^
In file included from node/kernel_notifications.cpp:5:
./node/kernel_notifications.h:40:74: error: non-virtual member function marked 'override' hides virtual member function
   40 |     void warningSet(const std::string& id, const bilingual_str& warning) override;
      |                                                                          ^
./kernel/notifications_interface.h:41:18: note: hidden overloaded virtual function 'kernel::Notifications::warningSet' declared here: type mismatch at 1st parameter ('const int &' vs 'const std::string &' (aka 'const basic_string<char> &'))
   41 |     virtual void warningSet(const std::string& id, const bilingual_str& warning) {}
      |                  ^
In file included from node/kernel_notifications.cpp:5:
./node/kernel_notifications.h:42:46: error: non-virtual member function marked 'override' hides virtual member function
   42 |     void warningUnset(const std::string& id) override;
      |                                              ^
./kernel/notifications_interface.h:42:18: note: hidden overloaded virtual function 'kernel::Notifications::warningUnset' declared here: type mismatch at 1st parameter ('const int &' vs 'const std::string &' (aka 'const basic_string<char> &'))
   42 |     virtual void warningUnset(const std::string& id) {}
      |                  ^
4 errors generated.
make[2]: *** [Makefile:10596: node/libbitcoin_node_a-kernel_notifications.o] Error 1
make[2]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[1]: *** [Makefile:20129: install-recursive] Error 1
make[1]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make: *** [Makefile:754: install-recursive] Error 1

Exit status: 2