Skip to content

blockstorage: Don't move cursor backwards in UpdateBlockInfo

Cirrus CI / tidy failed May 10, 2024 in 2m 23s

Task Summary

Instruction ci failed in 02:15

Details

✅ 00:03 clone
✅ 00:01 merge_base
❌ 02:15 ci

  CXX      kernel/libbitcoin_node_a-checks.o
  CXX      kernel/libbitcoin_node_a-coinstats.o
  CXX      kernel/libbitcoin_node_a-context.o
  CXX      kernel/libbitcoin_node_a-cs_main.o
  CXX      kernel/libbitcoin_node_a-disconnected_transactions.o
  CXX      kernel/libbitcoin_node_a-mempool_persist.o
  CXX      kernel/libbitcoin_node_a-mempool_removal_reason.o
  CXX      node/libbitcoin_node_a-abort.o
  CXX      node/libbitcoin_node_a-blockmanager_args.o
  CXX      node/libbitcoin_node_a-blockstorage.o
  CXX      node/libbitcoin_node_a-caches.o
  CXX      node/libbitcoin_node_a-chainstate.o
  CXX      node/libbitcoin_node_a-chainstatemanager_args.o
  CXX      node/libbitcoin_node_a-coin.o
  CXX      node/libbitcoin_node_a-coins_view_args.o
  CXX      node/libbitcoin_node_a-connection_types.o
  CXX      node/libbitcoin_node_a-context.o
  CXX      node/libbitcoin_node_a-database_args.o
  CXX      node/libbitcoin_node_a-eviction.o
  CXX      node/libbitcoin_node_a-interface_ui.o
  CXX      node/libbitcoin_node_a-interfaces.o
  CXX      node/libbitcoin_node_a-kernel_notifications.o
node/blockstorage.cpp:1154:17: error: redefinition of 'blockPos'
 1154 |     FlatFilePos blockPos{FindNextBlockPos(nBlockSize, nHeight, block.GetBlockTime())};
      |                 ^
node/blockstorage.cpp:1150:17: note: previous definition is here
 1150 |     FlatFilePos blockPos;
      |                 ^
1 error generated.
make[2]: *** [Makefile:10434: node/libbitcoin_node_a-blockstorage.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[1]: *** [Makefile:20107: install-recursive] Error 1
make[1]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make: *** [Makefile:754: install-recursive] Error 1
Build failure. Verbose build follows.
+ echo 'Build failure. Verbose build follows.'
+ make install V=1
Making install in src
make[1]: Entering directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[2]: Entering directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
/usr/bin/ccache clang++-18 -std=c++20 -DHAVE_CONFIG_H -I. -I../src/config  -fmacro-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=.  -DHAVE_BUILD_INFO -DPROVIDE_FUZZ_MAIN_FUNCTION -I. -I./minisketch/include -I./secp256k1/include -I./univalue/include -I./leveldb/include -I/usr/include -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_NO_CXX98_FUNCTION_BASE       -g -O2 -fdebug-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=.  -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wno-unused-parameter -Wno-self-assign -Werror    -O0 -g0 -c -o node/libbitcoin_node_a-blockstorage.o `test -f 'node/blockstorage.cpp' || echo './'`node/blockstorage.cpp
node/blockstorage.cpp:1154:17: error: redefinition of 'blockPos'
 1154 |     FlatFilePos blockPos{FindNextBlockPos(nBlockSize, nHeight, block.GetBlockTime())};
      |                 ^
node/blockstorage.cpp:1150:17: note: previous definition is here
 1150 |     FlatFilePos blockPos;
      |                 ^
1 error generated.
make[2]: *** [Makefile:10434: node/libbitcoin_node_a-blockstorage.o] Error 1
make[2]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make[1]: *** [Makefile:20107: install-recursive] Error 1
make[1]: Leaving directory '/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
make: *** [Makefile:754: install-recursive] Error 1

Exit status: 2