-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run code coverage on every PR #747
Run code coverage on every PR #747
Conversation
09d83fd
to
49a20df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 49a20df
Waiting for the CI to finish before merging this
In this way we can check how much of a PR is covered by the tests, making the review process slightly easier.
49a20df
to
1c4d478
Compare
I had to re-push to trigger the CI, but it should be good now 👍🏻 |
d9c1f87
to
89e8cab
Compare
- Remove default and minimal, as they are redundant - Use lexicographic order
89e8cab
to
aa0ea6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK aa0ea6a
verified PR branch code coverage runs can be found here: https://coveralls.io/github/bitcoindevkit/bdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK aa0ea6a
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing