Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the code coverage with different features #748

Conversation

danielabrozzoni
Copy link
Member

Description

Based on #747

This runs multiple codecov jobs and then merges the results all together. This increases the report precision, as we make sure to run tests with all the features.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • I'm linking the issue being fixed by this PR

In this way we can check how much of a PR is covered by the tests,
making the review process slightly easier.
@danielabrozzoni danielabrozzoni marked this pull request as draft September 9, 2022 21:48
@danielabrozzoni
Copy link
Member Author

This doesn't really seem to work...
What I'm trying to do is: run multiple tests with different features and then merge the coveralls reports.
This gives some weird results with esplora and electrum - for example, the coverage of the electrum module actually decreased, even tho we're still testing with all the electrum features!
The problem is probably that coveralls has to merge reports with different source codes (different features -> different source code), which leads to a wrong result.

@danielabrozzoni danielabrozzoni deleted the fix/code_coverage_parallel_builds branch October 11, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant