-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbkdf2 performance vs sjcl #21
Comments
small repo to test with: https://github.com/rubensayshi/pbkdf2-benchmark @dcousens said he was experiencing sjcl to be slower, maybe something different about his test case |
ios is also factor 10x and is by far the worst, pdkdf2 takes 23s, sjcl 2.8s |
maybe something along the lines of; blocktrail@a49b3d7 always seems hard to swap out certain parts for browserify... |
@rubensayshi what version of browserify are you using? My iOS mobile takes exactly 2.2s in a cordova build ... |
|
did you try that benchmark repo I made @dcousens, are you getting different results than me? because desktop chrome and android also are a lot slower .... |
also, if I try my small benchmark repo I'm getting a lot better results for ios than in the app I was initially testing it in, still sjcl is faster though. so I gotta go investigate ... |
@rubensayshi might close this here in favour of browserify/pbkdf2#18? |
aye |
I was trying to figure out how to optimize bip39 a bit for mobile (cordova), the
sjcl
package is about 10x faster for me than thepbkdf
package, could be interesting to switch?./configure --with-sha512 --with-hmac --with-pbkdf2 --with-bitArray && make
the sjcl, the default npm package does not contain sha512.... *The text was updated successfully, but these errors were encountered: