Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace script type strings with constants #683

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Replace script type strings with constants #683

merged 1 commit into from
Nov 4, 2016

Conversation

dcousens
Copy link
Contributor

@dcousens dcousens commented Nov 4, 2016

Rebase of #679

Will merge after ACK from @afk11
@afk11 just post merge ACK please

@dcousens dcousens added this to the 3.0.0 milestone Nov 4, 2016
@dcousens dcousens merged commit b5e46c2 into master Nov 4, 2016
@dcousens dcousens deleted the scriptconst branch November 4, 2016 01:21
@afk11
Copy link
Contributor

afk11 commented Nov 4, 2016

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants