Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss packet in CRTP RX dispatch #434

Closed
ataffanel opened this issue Jun 5, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@ataffanel
Copy link
Member

commented Jun 5, 2019

When a packet is received, it is dispatched to the correct port. This dispatch is currently using 1 packet queues and if the packet is not pulled fast enough by the port, the packet is just dropped.

We should instead relax a little bit the queues by adding more slot so that the task handling the port has time to get the data. At the same time we can add an ASSERT when a packet is dropped: lets have as a goal to never loose any packet and to design the communication protocol so that the transfer is throttled by design (like only allowing to send a new request when the previous answer has been received or to pull data fast enough in the Crazyflie so that it is not possible to fill up the port queue).

The proposal is to have 16 packets queue for each CRTP RX port.

@ataffanel ataffanel closed this in 00e0fcf Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.