pm: Increase delay before powering system #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating the Lighthouse deck as part of the flashing procedure we sometiems get stuck. The Lighthouse deck does not power on. We suspect this is connected to the capacitors on the deck not getting enough time to discharge in some conditions on some boards. Some users tried out firmware with 250 ms and 300 ms delays and the 300 ms delay fixed the issue for them. We increase the delay here to 350 ms to err on side of caution. If boot-up times becomes an issue we could change this to only take effect on soft-resets. Fixes: bitcraze#56
jonasdn
requested review from
ataffanel,
evoggy,
knmcguire,
krichardsson and
tobbeanton
ataffanel
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the Lighthouse deck as part of the flashing procedure we
sometiems get stuck. The Lighthouse deck does not power on.
We suspect this is connected to the capacitors on the deck not getting
enough time to discharge in some conditions on some boards.
Some users tried out firmware with 250 ms and 300 ms delays and the 300
ms delay fixed the issue for them. We increase the delay here to 350 ms
to err on side of caution.
If boot-up times becomes an issue we could change this to only take
effect on soft-resets.
Fixes: #56