Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToAlias, ToAliasReference for <=16-tuples #328

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

ivanbakel
Copy link
Contributor

@ivanbakel ivanbakel commented Aug 15, 2022

This adds a ToAlias and ToAliasReference instance for every tuple size from 9 to 16. These tuple sizes are supported elsewhere, but those typeclasses only had instances for tuples up to size 8.

This also adds from* functions for tuples of size 9-16, which didn't exist before.

Do I need to add Haddocks and @since declarations for these functions, given that they're in the Internal module?

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

This adds a `ToAlias` and `ToAliasReference` instance for every tuple
size from 9 to 16. These tuple sizes are supported elsewhere, but those
typeclasses only had instances for tuples up to size 8.

This also adds `from*` functions for tuples of size 9-16, which didn't
exist before.
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

I'm going to merge and release for 3.5.10.0

@parsonsmatt parsonsmatt added this to the 3.5.10.0 milestone Jun 8, 2023
@parsonsmatt parsonsmatt merged commit 6f884d8 into bitemyapp:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants