-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a class for backend compatibility #53
Conversation
This PR now uses the backend compatibility class introduced in The work project "just worked" with this patch and the new persistent, so I suspect it's fine. I'll try to find someone with heavier usage of the |
I've opened this PR in |
Using both this PR and the persistent one you linked, I still get this error:
Persistent queries work correctly. It's a mysql db on |
@dariooddenino Try with latest commit of |
Just a note: |
Does this works for |
@dariooddenino I have added tests for the @bitemyapp This is working and relying on Hackage |
@parsonsmatt I lean towards doing major bumps whenever in doubt. I will have time this weekend to help with this too. |
Cool. If you're good with a major bump for this, then Im happy with that too. Anything we want to get in with this version? |
@parsonsmatt other than any relevant persistent and conduit upgrades? Not that I'm aware of off-hand but I'll re-peruse the diff and be more certain after I've done so. You got anything in mind? |
Idk, there's probably some deprecations or stuff that can make the interface better? |
@parsonsmatt I have some work to do yet on cleaning up the test suite but this is now merged. Thank you very much! |
This PR will enable Esqueleto queries to be used by the
persistent-typed-db
library, along with other database backends.This is a WIP, please don't merge until I've had time to use it in-anger.