-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Findfiles func to find files recursively #36
Conversation
Are you ready for a review yet @mainawycliffe or are you still working on it? |
I am ready for a review. I think we can add glob to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mainawycliffe! This looks great. Just a few nitpicks I've pointed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Everything with the FindFiles feature is complete, I think, so it's just finalising the details of the todos
example now.
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
no problem @bitfield, that happens all the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a couple of minor tweaks to give this the final polish!
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
Taken care of the changes requested above. |
Great work, @mainawycliffe! Do you mind if I give this a final pass for style, consistency, squash commits, etc? |
No, I don't. |
Thanks again for the feature, and all your patient collaboration @mainawycliffe. |
Thanks too, learned a lot. Any new issue that I can work on? |
I think what we could most use is some substantial, non-trivial, useful programs written using |
Add a
FindFiles
func that will find files recursively in all directories (#35)NOTE:
I wanted the method to accept glob, but its behaving strangely in go. When you pass
dir/**/*.txt
, it only finds files inside the subdirectories ignoring all files in the root directory.